ip5306 about esphome_components

[ssieb]

In order to see setup messages, you have to watch the serial logs over USB.

[MichaKersloot]

Ah, yes, that works. I also found out the battery level only updates on a device reset.

[MichaKersloot]

As the battery level only updated on a device reset, I've changed the component from Component to PollingComponent. The diffs:

ip5306.h

@@ -8,10 +8,11 @@
 namespace esphome {
 namespace ip5306 {
 
-class IP5306 : public i2c::I2CDevice, public Component {
+class IP5306 : public i2c::I2CDevice, public PollingComponent {
  public:
+  IP5306() : PollingComponent(60000) {}
   void setup() override;
-  void loop() override;
+  void update() override;
 
   float get_setup_priority() const override;

ip5306.cpp

@@ -25,7 +25,7 @@ void IP5306::setup() {
   }
 }
 
-void IP5306::loop() {
+void IP5306::update() {
   uint8_t data[2];
   if (this->battery_level_ != nullptr) {
     if (this->read_register(IP5306_REG_LEVEL, data, 1) != i2c::ERROR_OK) {
@@ -40,8 +40,7 @@ void IP5306::loop() {
       case 0x80: value = 75; break;
       case 0x00: value = 100; break;
     }
-    if (!this->battery_level_->has_state() || (this->battery_level_->state != value))
-      this->battery_level_->publish_state(value);
+  this->battery_level_->publish_state(value);
   }
   if (this->read_register(IP5306_REG_READ0, data, 2) != i2c::ERROR_OK) {
     ESP_LOGE(TAG, "unable to read status");

[landonr]

what device are you using? I think my m5stack fire gets battery level updates with the current implementation but I'll check to be sure

[MichaKersloot]

Hi, I've activated the ip5306 on my T-Journal as stated in https://discord.com/channels/429907082951524364/951213660905287761/1061049798402265228 . It looks like
the removed if statement is not doing what you expect? I suspect it only publishes the state on the first run to create it and never runs again. To me it also seems better to use the PollingComponent instead of Component to limit the updates to a reasonable rate.

[ssieb]

I don't see what that PR fixes. The current code will update when the battery level changes. If that's not working, then polling is not going to work either since it's still the same code.

[MichaKersloot]

The code only publishes on a device reset. Or maybe when the battery level changes, i've not seen this happening. This means when Homeassistant restarts there is no value reported and it's shown as NA. So changing it to a PollinComponent that reports the current value on polling fixes this. Both changes work together.