Comments (3)
I committed c1a621a, which I think covers it. let me know if there's still an issue.
from cmake-scripts.
Thank you, that looks good.
Though I am curious about the intended behavior of the cppcheck logic in tools.cmake
. There's a if (CPPECHECK)
check (note the typo) here that will evaluate to false due to the typo, however the logic inside that check's body is modifying the CMAKE_CXX_CPPCHECK
variable with additional cppcheck flags. But when the cppcheck()
macro is invoked, the CMAKE_CXX_CPPCHECK
is overwritten and wipes out the cppcheck flags that were applied earlier. Are those flags supposed to persist, or is that an old approach for applying cppcheck flags that's no longer meant to be used?
from cmake-scripts.
Honestly, I'm not entirely sure anymore. Much of the implementation is several years old.
However, as you do note it was a bit confusing, so I've gone ahead and re-worked the implementation (ba83421), and hopefully made things much clearer.
I've gone fully down the road of giving better control of the tools to the calling scripts, and the ability to overwrite/clear flags at-will throughout.
Let me know if what it is now is still unclear, or what parts of it are, and I'll try to fix/make things even clearer.
from cmake-scripts.
Related Issues (20)
- cmake-format 0.6.2 released HOT 1
- Release verion HOT 2
- Support for Interfaces HOT 1
- Broken macros in tools.cmake HOT 1
- Incompatibility with FindMPI HOT 1
- `ccov-clean` not compatible on Windows HOT 4
- `ccov-all*` not compatible on Windows HOT 2
- Excluding dependencies in code coverage reports HOT 11
- Build fails with `lcov` HOT 2
- Question: Why doesn't the `link-time-optimization.cmake` script work with GCC? HOT 1
- Question: code coverage on all targets HOT 1
- Exclusions do not work for ccov-all-* targets HOT 2
- [bug] the codecov showed the wrong cov range HOT 2
- Error when run llvm-cov in hithub ubuntu-latest HOT 1
- Suggestion: Merge with cmake-compiler-flags
- Cross-compilation support HOT 4
- Support for custom code coverage analysis tools
- ccov-all-export on Windows HOT 1
- Main page readme reports functionalities not available in latest release HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cmake-scripts.