GithubHelp home page GithubHelp logo

Comments (3)

StableCoder avatar StableCoder commented on July 27, 2024

I committed c1a621a, which I think covers it. let me know if there's still an issue.

from cmake-scripts.

cconverse711 avatar cconverse711 commented on July 27, 2024

Thank you, that looks good.

Though I am curious about the intended behavior of the cppcheck logic in tools.cmake. There's a if (CPPECHECK) check (note the typo) here that will evaluate to false due to the typo, however the logic inside that check's body is modifying the CMAKE_CXX_CPPCHECK variable with additional cppcheck flags. But when the cppcheck() macro is invoked, the CMAKE_CXX_CPPCHECK is overwritten and wipes out the cppcheck flags that were applied earlier. Are those flags supposed to persist, or is that an old approach for applying cppcheck flags that's no longer meant to be used?

from cmake-scripts.

StableCoder avatar StableCoder commented on July 27, 2024

Honestly, I'm not entirely sure anymore. Much of the implementation is several years old.

However, as you do note it was a bit confusing, so I've gone ahead and re-worked the implementation (ba83421), and hopefully made things much clearer.

I've gone fully down the road of giving better control of the tools to the calling scripts, and the ability to overwrite/clear flags at-will throughout.

Let me know if what it is now is still unclear, or what parts of it are, and I'll try to fix/make things even clearer.

from cmake-scripts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.