Comments (6)
Thanks for your feature request.
I didn't know JSON5. Number of sources I consulted:
from dnscontrol.
Could you supply a sample json5 file we can test against?
from dnscontrol.
Would you consider submitting a PR?
The JS interpreter we use is github.com/xddxdd/ottoext
. If it supports JSON5, this is easy. Modify pkg/js/js.go
(there is a function called "require") to handle this as a special case.
If otto doesn't support JSON5, you'll have more work to do. Perhaps convert JSON5 to JSON and handle it that way.
from dnscontrol.
Would you consider submitting a PR?
The JS interpreter we use is
github.com/xddxdd/ottoext
. If it supports JSON5, this is easy. Modifypkg/js/js.go
(there is a function called "require") to handle this as a special case.If otto doesn't support JSON5, you'll have more work to do. Perhaps convert JSON5 to JSON and handle it that way.
I didn't use any JSON5 feature except commenting, and that works with extension json
from dnscontrol.
however, modern IDE would warn using comments in json, so supporting json5 would be a great idea, only support that extension is ok.
from dnscontrol.
Feature added! Enjoy!
from dnscontrol.
Related Issues (20)
- MacPorts included in install instructions, but not maintained? HOT 16
- Release failed HOT 5
- Refactor how rtypes are implemented HOT 2
- [4.12.3] Unsupported record type CLOUDFLAREAPI_SINGLE_REDIRECT HOT 1
- Difference in preview stdout with 4.12.3 HOT 2
- CF_REDIRECT() should output new-style language HOT 1
- [4.12.4] CF_SINGLE_REDIRECT name not applied HOT 2
- Support YAML in credentials configuration file HOT 5
- Service Provider Specific domain-modifiers not appearing on website HOT 4
- add ability to "fmt' to output sorted records HOT 2
- Add MTA-STS_BUILDER HOT 1
- [BUG] `go install` instructions do not work HOT 8
- Gitter - Drop communication channel
- NS1: URFLWD is deprecated HOT 3
- Add LUA Record support HOT 1
- New registrar: Porkbun HOT 4
- Azure DNS - Add additional nameserver to zone returns error about multiple entries HOT 1
- Oracle - Provider leaves trailing dot on nameserver
- Running DNSControl in Termux (Android) Output Always Get Stuck HOT 8
- Update Oracle SDK
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dnscontrol.