require json5 file? about dnscontrol

[cafferata]

Thanks for your feature request.

I didn't know JSON5. Number of sources I consulted:

• https://json5.org
• https://github.com/json5/json5

[tlimoncelli]

Could you supply a sample json5 file we can test against?

[tlimoncelli]

Would you consider submitting a PR?

The JS interpreter we use is github.com/xddxdd/ottoext. If it supports JSON5, this is easy. Modify pkg/js/js.go (there is a function called "require") to handle this as a special case.

If otto doesn't support JSON5, you'll have more work to do. Perhaps convert JSON5 to JSON and handle it that way.

[lolifamily]

Would you consider submitting a PR?

The JS interpreter we use is github.com/xddxdd/ottoext. If it supports JSON5, this is easy. Modify pkg/js/js.go (there is a function called "require") to handle this as a special case.

If otto doesn't support JSON5, you'll have more work to do. Perhaps convert JSON5 to JSON and handle it that way.

I didn't use any JSON5 feature except commenting, and that works with extension json

[lolifamily]

however, modern IDE would warn using comments in json, so supporting json5 would be a great idea, only support that extension is ok.

[tlimoncelli]

Feature added! Enjoy!