GithubHelp home page GithubHelp logo

Comments (4)

Acaccia avatar Acaccia commented on June 6, 2024

stx-transfer-memo? and stx-transfer both use the exact same stdlib.transfer-memo wasm function. Current unit tests already cover the unhappy paths.

from clarity-wasm.

csgui avatar csgui commented on June 6, 2024

Just noticed that. Thanks for pointing @Acaccia ! 👍

https://github.com/stacks-network/clarity-wasm/blob/main/clar2wasm/src/words/stx.rs#L75

https://github.com/stacks-network/clarity-wasm/blob/main/clar2wasm/src/words/stx.rs#L105

Closing this issue as it is no longer necessary.

from clarity-wasm.

Acaccia avatar Acaccia commented on June 6, 2024

My comment was not necessarily about this issue being unnecessary, but it was more the fact that the current tests could be copied for stx-transfer-memo?.

I think it's important to add them in case we refactor those functions later, so I'll reopen this issue.

from clarity-wasm.

csgui avatar csgui commented on June 6, 2024

I think it's important to add them in case we refactor those functions later, so I'll reopen this issue.

Oh, I see! I misunderstood your comment. Thanks!

from clarity-wasm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.