Comments (6)
Is there a reason this method is preferred over using SIP018 with a string-ascii
type? The SIP018 document describes some potential issues with "non-structured messages". For example, potential replayability issues depending on how the app dev formats the message, as well as the ability for wallet software to display sign in (and future) message types more nicely. Since some apps are broken right now due to the recent change, I would suggest them to simply move to SIP018 since it is implemented and shows the app name and version.
Nonetheless, at Ryder have not implemented non-structured signing due to there not being a standard yet. If it were adopted as a SIP it be safer for devs to rely on the functionality.
from sips.
From my understanding from the last SIP call when this item was discussed Friedger and Jude were present, the conclusion on the I believe was to just for this to be part of SIP-018. Will let the others confirm this.
from sips.
Hi @kyranjamie @MarvinJanssen since SIP-018 will activate with SIP-015 (provided Stacks 2.1 vote will be a pass), do you guys need to make any amends to SIP-018 based on this above conversation?
from sips.
I made this issue to note that there's no SIP covering this functionality, that's currently supported by the Hiro Wallet and Ledger Stacks app.
I'm no advocate for it, though. @MarvinJanssen's right that developers should favour SIP-018 going forward. Perhaps this functionality is better considered non-standard, not covered by a SIP, and eventually deprecated—that's up to Stacks app developers/community.
I don't believe any action is necessary relating to upcoming SIP activations.
from sips.
Understood. Thank you Kyran for bringing this to people's awareness!
from sips.
@Hero-Gamer it also does not make sense to me to include it in SIP018 as the message signing described in the OP is quite different.
from sips.
Related Issues (20)
- Create template for CAB minutes HOT 1
- Draft SIP for apps requesting BTC transactions from wallet HOT 1
- SIP001, SIP002 and SIP004 still refer to Blockstack, should that be changed to Stacks? HOT 1
- sBTC has token ticker collisions, should it be changed? HOT 3
- Wallet client API HOT 7
- Updated Harberger Tax Model for BNS HOT 18
- NFT(s) Staking SIP Research
- Draft SIP for ZK Verification Clarity Primitive HOT 1
- Documenting the SIP approval process
- Wishlist: Step by step tutorial to run a stacks node (w/o docker) - and/or single click install options HOT 1
- Understanding multiple trait definitions HOT 2
- Bug: SIP-005 states that stx transfer transaction can't be sponsored
- Weekly SIP Meeting Agenda & Notes HOT 32
- Use more GitHub labels
- Document members of the Steering Committee HOT 3
- Steering Committee Monthly SIP call - Agenda & Notes HOT 7
- Draft for Standard trait definition for extending tokens HOT 16
- Quick test - please disregard HOT 3
- Reference List of Traits for Mainnet and Testnet HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sips.