Comments (15)
Did you reenable StampieExtra? It uses the events from the extra functionality to log message.
This could be improved by decorating the mailer.
from stampie-bundle.
@henrikbjorn decorating the mailer is exactly what StampieExtra does :)
from stampie-bundle.
@stof yeah, should really get those things merged together :)
from stampie-bundle.
@henrikbjorn Still active yes :/
The MessageLogger:preSend is well called, and I do have the debug line in my logs:
sprintf('Sending an email from "%s" to "%s"', IdentityUtils::buildIdentityString($message->getFrom()), IdentityUtils::buildIdentityString($message->getTo())),
This is my timeline at the moment:
// Logs added in the MessageLogger:preSend method
[2014-07-18 16:32:20] app.ERROR: Adding a message in the message logger [] []
[2014-07-18 16:32:20] app.ERROR: Messages before addition: 0 [] []
[2014-07-18 16:32:20] app.ERROR: Messages after addition: 1 [] []
Then I logged the StampieDataCollector:collect
method.
[2014-07-18 16:32:21] app.INFO: Message logger is not null [] []
[2014-07-18 16:32:21] app.INFO: Messages in the logger: 0 [] []
So the first logs are displayed first in the timeline, then the collect method is called many times, but always at 0.
from stampie-bundle.
@Ninir where in you application do you send the messages? Are you using the SpoolMailer?
from stampie-bundle.
@henrikbjorn Right from a controller, and the kernel.terminate
is well called. However, it happens even in a command, in a listener, etc. :/
Not sure where the issue comes from tbh.
from stampie-bundle.
if you use the spool mailer, the collector will indeed run too early (recent Symfony versions have a way to fix this, but it would break compatibility with older Symfony versions)
from stampie-bundle.
and in a command, the profiler does not run at all.
from stampie-bundle.
@stof How do you think we could handle it for a given project? This feature is an interesting one but not usable atm.
I do am using the SpoolMailer :/
from stampie-bundle.
The issue is that 2.3 does not have the LateDataCollectorInterface (it is a 2.4 feature) and we cannot drop compatibility with 2.3 (it is the LTS).
I will look at a way to use the late collecting for 2.4+ with a fallback to the current way for 2.3 (so that 2.4+ gets the data for messages sent in kernel.terminate as well). but only after my vacations (I'm leaving for 2 weeks)
from stampie-bundle.
@stof Ok perfect, thanks for this! ;)
from stampie-bundle.
When can we drop 2.3 support?
from stampie-bundle.
I would say now since 2.7 is the new LTS. However, 2.3 Will be maintained until may, 2016.
Le 31 mai 2015 à 17:48, Henrik Bjørnskov [email protected] a écrit :
When can we drop 2.3 support?
—
Reply to this email directly or view it on GitHub.
from stampie-bundle.
Then lets do that, i dont really care for supporting an old LTS. Also lets just tag a new major anyway.
from stampie-bundle.
@henrikbjorn Sure, would be awesome :)
Thank you for your time!
from stampie-bundle.
Related Issues (13)
- Move to Flint organization. HOT 8
- Please tag a new stable version of the bundle HOT 1
- SpoolMailer configuration
- Mailgun uses Postmark Class
- Fix namespace to match the new organization name. HOT 3
- Improve support for the new profiler design
- Improve travis.yml config HOT 1
- Write change log HOT 1
- Update documentation HOT 1
- Composer package should be renamed before 2.0 HOT 2
- Cannot Use Mandrill mailer as a dependency because it is abstract HOT 1
- Support for Symfony 2.3 LTS HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stampie-bundle.