Some of these models don't compile with Stan 2.17.1+ about example-models

[mitzimorris]

I used cmdstan to make all the ARM models, and the following failed to compile:

ARM/Ch.21/r_sqr.hpp
ARM/Ch.21/finite_populations.hpp
ARM/Ch.21/multiple_comparison.hpp
ARM/Ch.17/17.6_multilevel_ordered_categorical.hpp
ARM/Ch.17/17.2_radon_correlation.hpp
ARM/Ch.17/17.1_radon_correlation.hpp
ARM/Ch.17/17.2_radon_vary_inter_slope.hpp
ARM/Ch.17/17.2_radon_multi_varying_coef.hpp
ARM/Ch.17/17.7_robit.hpp
ARM/Ch.17/17.5_multilevel_poisson.hpp
ARM/Ch.17/17.1_radon_multi_varying_coef.hpp
ARM/Ch.17/17.7_latent_glm.hpp
ARM/Ch.17/17.2_radon_wishart.hpp
ARM/Ch.17/17.3_flight_simulator.hpp
ARM/Ch.17/17.4_multilevel_logistic.hpp
ARM/Ch.17/17.1_radon_vary_inter_slope.hpp
ARM/Ch.17/17.1_radon_wishart2.hpp
ARM/Ch.17/17.1_radon_wishart.hpp
ARM/Ch.23/educational_subsidy.hpp

working from develop on both cmdstan, stan:
cmdstan: v2.17.1-59-g395efdd
stan: v2.17.1-147-g30b902a0d

[bob-carpenter]

Those don't look like they'd ever have parsed.

What should we do with all these old ARM models? The new ARM is on its way, but that doesn't solve the immediate problem.

[danluu]

Linking this to #23 via github's magic autolinking since they look closely related.

[mitzimorris]

checked compilation of BUGS models - 2 don't compile:

bugs_examples/vol3/fire/fire.hpp
bugs_examples/vol2/pines/pines-3.hpp

[mitzimorris]

these 3 ARM models don't compile; can't figure out what to do by looking at BUGS code in ARM Ch. 21:

example-models/ARM/Ch.21/finite_populations.stan
example-models/ARM/Ch.21/multiple_comparison.stan
example-models/ARM/Ch.21/r_sqr.stan