Comments (4)
Thinking about how this relates to uses of variable names across the API, this seems related to the inconsistent handling of indices in variable names between draws_rvars and the other formats (see here: #208 (comment))
One thought is to fix the above-referenced issue so that something like variables(x, with_indices = TRUE)
(default) returns names like x[1,1]
, x[1,2]
, ... and variables(x, with_indices = FALSE)
returns names like x
. Then have clear indications in the API of which functions take variable names with or without indices.
For this issue specifically, following the pattern of extract_variable_matrix()
we could have an extract_variable_array(x, variable)
that takes a variable name without indices and returns its array form. Then the solution in the above example would be extract_variable_array(x, "z_1")[1,,]
.
If we also want a solution specifically for getting one draw regardless of shape, then there is helper code used by for_each_draw that could be extracted and adapted for that purpose.
from posterior.
Cool, happy to take a stab at it.
from posterior.
I did also notice the index-inconsistency, and like the idea of with_indices
extract_variable_array
would work for me (the first use case is stan-dev/cmdstanr#876)
from posterior.
I agree. Sounds like a good solution.
from posterior.
Related Issues (20)
- should remove_variables be exported? HOT 4
- Dealing with chains of different length HOT 1
- rvar strange behavior HOT 2
- Add functions for PIT and LOO-PIT HOT 6
- .args in summarise draws incompatible with summary functions without ellipses HOT 10
- `pareto_khat(..., tail="both")` returns NA if just one tail is constant
- pareto diagnostics return named values, preventing renaming
- validate_weights allows NaN and NA weights
- [FR] Allow as_draws_dt for data.table HOT 9
- New draws_tensor format? HOT 4
- Applying a function to each chain HOT 1
- In summarise draws, a function that returns a character changes all columns to character HOT 4
- export ps_khat_threshold HOT 4
- pareto_khat should always return the same data structure
- `ps_khat_threshold` can return values greater than 0.7 HOT 2
- Errors when `rvar` is made from a data frame HOT 3
- subset_draws duplicates variables if `variables` argument contains `NA` HOT 4
- New CRAN release? HOT 6
- default for `r_eff` in `pareto_smooth()` and `pareto_khat()` differ
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from posterior.