Doesn't build on artix ( arch ) linux about stargate

[yust1n]

https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=stargate
did it my way ... seems to works now

[L3337]

Hi @yust1n ,

I actually made a bunch of changes to how it installs now, thanks for reminding me that I forgot to update the pkgbuild.py script. The new way that I'm packaging everything is to install everything in a single folder in /opt/stargate using make install_self_contained, and then symlink in /usr/share files like desktop files, icons, /usr/bin/stargate, etc... using make install_symlinks. Which ultimately simplifies the installation and allows switching between multiple installations just by calling them directly or changing the system symlinks (not that there is really a reason to have mutiple versions installed though).

Thanks for updating AUR. It looks good, only concern is that you are deleting Soundtouch? I'm assuming that will break time stretching for audio items, but maybe I'm misunderstanding what is happening in your PKGBUILD. Also, unless I'm misunderstanding something again, it looks like you are not adding the symlinks to the desktop files, /usr/bin/stargate, etc... so it would have to be invoked with /opt/stargate/scripts/stargate? I guess this line is removing the symlinks:

	sed "/\binstall_symlinks:/s/:.*/:/" -i Makefile 

, the question is: What was happening that caused you to remove it? Probably permissions issues?

After looking at, I think I need to replace things like:

    ln -s /opt/stargate/scripts/stargate \                                         
        $(DESTDIR)$(PREFIX)/bin/stargate || true 

with

    ln -rs $(DESTDIR)/opt/stargate/scripts/stargate \                                         
        $(DESTDIR)$(PREFIX)/bin/stargate || true 

But I will wait for your feedback before I make any changes.

[L3337]

I found a number of issues in the build system, so I went ahead and committed 5bb7f87. That will probably solve all of your problems, and allow you to just do a simple make install without the extra hackery around it. I'm not sure if Arch/AUR and their derivatives have Soundtouch in their repos (or if Stargate will be able to find the system version), but please do test time stretching audio with the default Soundtouch algorithm and let me know.

[yust1n]

Don't worry ... all is fine !!!!
Just checked and icons are there ... didn't think of that because i do all the stuff in the shell.
The sed just removes the call in the Makefile to remove the symlinks ... breaks the build since there are no symlinks to delete.
damn ... lol .... crosspost ....
There is no issue anymore with my PKGBUILD but now there might be new ones :D
rm -rf src/vendor/soundtouch/ and rm -rf src/vendor/portaudio-binaries/ just delete empty dirs so git submodule works proper.
Anyways I am damn tired .... will have a look at what you did tomorrow.

[L3337]

there is no issue anymore with my PKGBUILD but now there might be new ones :D

Yeah, the life of a package maintainer, I maintain some packages also :-D

Let me know if you run into any problems. I have no plans of making more changes to the build system (unless you report any other issues I need to fix), so it should be stable after this.

[L3337]

Also, these lines should be able to go away:

	mkdir -p ${pkgdir}/usr/bin
	mkdir -p ${pkgdir}/usr/share/{doc,applications,pixmaps}
	mkdir -p ${pkgdir}/usr/share/mime/packages

That was another bug that I fixed.

EDIT: If using the default symlinking mechanism in the stock Makefile

[L3337]

Fixed pkgbuild.py as well. Couldn't run Stargate on my Manjaro VM because they broke the PyQt6 package by pairing it with an older version of Qt6, but everything appeared to install correctly. This is my PKGBUILD with the new fixes:
https://github.com/stargatedaw/stargate/blob/main/scripts/pkgbuild.py#L70-L83

[yust1n]

Nice :)
Since this PKGBUILD is based on releases i will take care when 23.05.02 will be out.
Thanks !

[L3337]

I'm in the middle of releasing right now. Thanks for the bug report and AUR packaging, not sure how I missed all of these issues, but glad to have them fixed.

[yust1n]

Thanks 23.05.2 i found a real big bug in my PKGBUILD !!!
I will update it tomorrow ... already did some tests and i feel really stupid now :D
Time to play with the new release .... I need to find out how to loop audio and stuff.

[L3337]

I will update it tomorrow ...

Awesome, I appreciate it :-) The AUR package went unmaintained for quite a while when an update to pacman broke it, grateful that you got it working again.

I need to find out how to loop audio and stuff.

Just right-click on the sequencer timeline and set the region start and end. Then click the loop button on the transport to toggle looping the region.

[yust1n]

Works now. I tested it with yay.
Finding out how to loop wasn't a big problem but playing with timestretch in the waveeditor gave me strange results.

[L3337]

but playing with timestretch in the waveeditor gave me strange results.

We basically just repackage all of the open source time stretching / pitch shifting libraries, with the exception of:

• Time (Affecting Pitch)
• Pitch (Affecting Time)

, which simply re-pitch the audio in real time.

The open source libraries have the following known issues:

• Soundtouch: Usually pretty accurate on time, but sometimes the pitch is not what it was supposed to be, depending on the content. Also, sometimes it massively distorts the audio, usually Rubberband is a better choice when this happens
• Rubberband: Generally sounds pretty good and is accurate on pitch, but often the accuracy of the length isn't 100%
• Paulstretch: Not accurate on time, meant for turning sounds into atmospheres by stretching/smearing them very much
• SBMS: Sometimes sounds strange, fairly accurate on pitch, often not very accurate on time, only works on Linux and Mac x86, does not work on ARM or Windows, where the option for it is hidden

If you ran into something else, please let me know. I'll create a separate issue for the time stretching known issues.