GithubHelp home page GithubHelp logo

Comments (12)

AlBirdie avatar AlBirdie commented on June 19, 2024

You're probably building with 3.7, correct?

from starling-extension-graphics.

mapetek avatar mapetek commented on June 19, 2024

Yes, i am using AIR SDK 3.7

from starling-extension-graphics.

Astraport avatar Astraport commented on June 19, 2024

Does anyone found a solution? In SDK 3.8 issue persists.

from starling-extension-graphics.

AlBirdie avatar AlBirdie commented on June 19, 2024

Did anyone else try the fix proposed in this thread: http://forum.starling-framework.org/topic/graphics-extension-release-build-problem?replies=10#post-44323?

For me that didn't do the trick.

from starling-extension-graphics.

Astraport avatar Astraport commented on June 19, 2024

Yes, my Fill issue fixed with help this thread.

from starling-extension-graphics.

AlBirdie avatar AlBirdie commented on June 19, 2024

Interesting. Could you make a pull request with your fixed Stroke class then? I might have missed something important.

from starling-extension-graphics.

Astraport avatar Astraport commented on June 19, 2024

You need use Inline version in isReflex() function too.

from starling-extension-graphics.

AlBirdie avatar AlBirdie commented on June 19, 2024

Got it. Cheers mate!
Just for the sakes of completeness, you must not use the Inline version in isPointInTriangle() and isReflex(), rather than the isLeft() function. Also, don't [Inline] isLeft() afterwards, that will cause the Fill to disappear again.

I guess we can consider this fixed (I'm happy to make a pull request later if required), though I'm absolutely clueless why the changed ASC2.0 compiler in AIR > 3.6 doesn't like the inlining in this particular case.

from starling-extension-graphics.

robsilv avatar robsilv commented on June 19, 2024

Hi guys, I've just merged @AlBirdie's pull request above. Please let us know if this solves your problems!

from starling-extension-graphics.

mapetek avatar mapetek commented on June 19, 2024

Hi @robsilv, i updated my source code and it worked but SWC does not. I think it is out-of-date.
Thank you all guys!

(I'm not closing issue yet for further comments)

from starling-extension-graphics.

IonSwitz avatar IonSwitz commented on June 19, 2024

I'm not sure what the policy is, should the SWC always represent the code, or do we do "releases" of the SWC at certain points? A few pull requests have been merged lately without the SWC being updated...

from starling-extension-graphics.

IonSwitz avatar IonSwitz commented on June 19, 2024

Closing this as the SWC now has been updated

from starling-extension-graphics.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.