GithubHelp home page GithubHelp logo

Comments (5)

lastzero avatar lastzero commented on May 13, 2024

A similar problem is the use of UTF-8 byte order marks in any file, as far as I remember from a past experience. The fix with the added new line char seems valid - but I'd like to wait for feedback from Brian or Justin.

from steal.

moschel avatar moschel commented on May 13, 2024

Yeah that fix looks good, but steal.end() isn't part of the latest steal anymore, so this might no longer be needed in 3.2.

Michael, what is the case where it broke for you? Is this the same fix for your issue? Does it still apply with the latest steal?

from steal.

lastzero avatar lastzero commented on May 13, 2024

Might fix it or not. Might also just be a problem when including css or less files (can't remember it anymore in detail). But I guess it's a good enough fix to simply disable byte-order marks in the editor - I don't know which editors add them, but there seem to be some.

from steal.

moschel avatar moschel commented on May 13, 2024

Ok. Well in that case I'm going to close this. If either of you find a breaking case still, let me know, or better yet, submit a pull with the breaking case.

from steal.

asavoy avatar asavoy commented on May 13, 2024

I would strongly suggest that there is some kind of warning, if a UTF BOM is found during build.

I have been bitten by the UTF BOM affecting build of production css files and I wasted several hours trying to work out why there was a difference between production and dev. I can't recall if it broke the first style in the file, or if it prevented the whole file from being included. Some editors will auto-inject a BOM when you type a non-ascii char, and other times, you may include a third-party css file without knowing that it's UTF-8 + BOM format.

from steal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.