Comments (11)
Yes, I agree! We should start doing it on a new branch. But someone need to drive the project with good practices and a good software architecture
from linter.
I'm somewhat experienced in creating distributed architectures but I guess I'm not fully aware of the coffeescript/js/atom-framework capabilities. I would like to suggest creating a AtomLinter/linter-core
-repository to standardize the repo-naming.
I would also like to suggest using GitHub to collaborate in the design-process - every idea to improve something is welcome. I could imagine the following tasks for the first milestone:
- requirement for publishing: code-coverage (with karma & jasmine) != 1.0
- full test-set for linter-core and linter-prototype (the new baseclass for linters, to be forked)
- a toggleable, scrollable bottom-info-pane for project-based configuration, debug-reporting, release-notes and project-announcements.
- a backward-compatibility-class "Linter", to catch up the old linters
- the polished, transparent, hovering lint-reporter next to the cursor
from linter.
We need to start a branch to pull in the standard atom testing framework. They have it set up with jasmine and fully ready for integration style testing. So there shouldn't be any real difficulty testing the existing implementation.
from linter.
Yeah, we should use the existing test-infrastructure. But we should probably also consider a refactoring of the classes and their responsibilities, to make the behaviour more consise and robust.
from linter.
Agreed. I think our primary initial goal should be to force a solid mvc separation and get the views broken out from their controllers. The pattern for separating along these lines in most of the atom code doesn't really seem to exist. I'm still researching good methodologies for breaking it out.
from linter.
In my 2nd package (gradle-ci) - i made good experience with a nearly rails approach: having a model and medium-weight views. I think it is possible to create a fully working mvc-approach if that is what we're searching for.
I'll create a discussable skeleton to let the idea become more precise.
from linter.
I am suggesting to use Promise/A+ pattern to replace the callback pattern. The current code is very hard to find out what is dealing with the callback.
from linter.
Promises, yes please,
I use Q and find it very pleasing :)
https://github.com/kriskowal/q
@lijunle do you want to tackle refactoring some of the callback hell?
from linter.
+1 q
from linter.
I use RSVP, but I'm okey with Q ;)
That's a good direction.
from linter.
@park9140 , I will do it if you guys accept the code.
from linter.
Related Issues (20)
- Fresh Atom Install with [email protected]/3, required packages are not installed/prompted HOT 4
- Replacement position does not change when replacement is applied further left
- release span HOT 13
- Atom Linter "highlight error lines in gutter" not showing in settings
- Unable to install 3.3 version of linter on windows
- Feature request: explicitly tell user that by default linter lints on save HOT 1
- linter-csslint:: Error while running CSSLint! HOT 1
- JS private fields error HOT 1
- AtomLinter is showing incorrect errors
- Linter is not honoring "Lint on Change" and "Lint on Change Interval" settings HOT 1
- disabled providers list not respected HOT 7
- Linter is not working HOT 7
- I HATE LINTER!!! NOW I CAN DELETE THIS IN ATOM OR DISABLED??? HOT 3
- Linter dropdown not functioning on some OS X platforms
- Linter timeout using ShellCheck
- Failed to install linter dependencies
- Beep sound on error
- Uncaught ReferenceError: 耽a is not defined
- Getting "Inavlid Point" Error with every linter plugin I try.
- Errors not showing on mac HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from linter.