Comments (24)
That is super-super weird but I'll investigate.
from package-deps.
Good thing this was linter-ruby
. π
from package-deps.
@k2b6s9j I am unable to repro. Can you make sure that you are on the latest version of atom?
This snippet executes without an error for me, does it produce an error for you?
a = atom.notifications.addError("some Error")
console.log(atom.views.getView(a))
from package-deps.
That snippet returns an atom-notification
element in the console...
from package-deps.
@k2b6s9j the code that's producing the error above, is the same code as this one. Probably that was a temporary weird error. Would you mind trying the linter-ruby thing again?
from package-deps.
Reloaded the window. Still happening.
from package-deps.
from package-deps.
How do I point NPM to that revision?
from package-deps.
Well, you clone the repo in node_modules folder and checkout that branch
from package-deps.
Ah. Thanks.
from package-deps.
ReferenceError: packageName is not defined
at /Users/kepler/.atom/packages/linter-ruby/node_modules/atom-package-deps/lib/view.js:17:70
from package-deps.
@k2b6s9j just pushed. Pull it and try again.
from package-deps.
Error no longer occurs. It now shows an Info notification, with a progress bar. But the progress bar doesn't seem to be making any progress. However, APM installs have always been kinda slow for me, I'll give it a minute or two.
from package-deps.
from package-deps.
Okay. It's making no indication of any progress.
from package-deps.
@k2b6s9j the progress bar doesn't make any progress for one package, it's like 0% to 100% at once because apm doesn't report it's install progress. However if you have more than one dependencies, then it'll mark one package installed as a progress point. I think I'll make the progress bar animate a bit.
from package-deps.
Okay.
from package-deps.
I think the install has stalled @steelbrain it still hasn't moved.
from package-deps.
@k2b6s9j can you check if linter-ruby
exists in ~/.atom/packages
?
There's no reason for it to be stalled, it worked fine for me on the first run π
But yes, we do need Unit Tests.
from package-deps.
linter-ruby
exists in ~/.atom/packages
, linter
does not. I'll restart Atom though and see if that works.
from package-deps.
Still not installing.
from package-deps.
@k2b6s9j writing unit tests. Give me a few minutes.
from package-deps.
Awesome. Alright.
from package-deps.
A confirmed fix is in v2.0.1
from package-deps.
Related Issues (20)
- maximum required version HOT 4
- Cannot configure package-deps to install package dependancies. HOT 2
- Installing package with dependencies fails on Windows HOT 11
- showPrompt fails HOT 7
- `packageDeps.install()` causes exception "querySelector is not a function" HOT 2
- Stop enabling the notifications package
- Optional dependencies HOT 2
- Can't bring up the integration HOT 7
- An in-range update of semver is breaking the build π¨ HOT 1
- Doesnβt prompt to install sub-dependencies
- Move package-deps to `apm` HOT 3
- Allow specifying a `package.json` for installation without Atom running
- 'patch-package' is not recognized as an internal or external command HOT 2
- Bring option for setting the prompt to off HOT 3
- packages installation for node fails on windows
- Cannot read property 'length' of undefined at lib/index.js:930:26 HOT 5
- Error during showing installation progress to user
- Dependencies fail to install when there is a space in Atom's install path HOT 2
- atom-ide-base main tests fail to activate the packages HOT 1
- Doesn't Recognize Github Format HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from package-deps.