Newly added functions lack version checks about pysodium

[stef]

i hardcoded the missing values in case they do not exist, also i removed the sodium_version_checks which are made obsolete by this (and i reordered some of the constants to make them more human friendly) in 1d00f0c.

[stef]

damn. sorry. fixing it right now.

[stef]

hmmmm. looks like there are some constants that have been only added in 1.0.12 but the crypto_pwhash_scryptsalsa208sha256 interface existed previously already since at least 1.0.8. dunno what the best course is, remove the sanity checks entirely for that interface, or enable them only if libsodium is >=1.0.12, and let the previous versions fly blindly?

[stef]

please confirm the fix of this bug by b38db7d by closing this issue.

[jvarho]

I found one more instance, see #84 .

looks like there are some constants that have been only added in 1.0.12 but the crypto_pwhash_scryptsalsa208sha256 interface existed previously already since at least 1.0.8. dunno what the best course is, remove the sanity checks entirely for that interface, or enable them only if libsodium is >=1.0.12, and let the previous versions fly blindly?

Another option would be to hardcode the values of those constants in 1.0.8...<1.0.12.

[stef]

ah, the hardcoding thing seems like the right solution to this problem, i'll do that! thanks for the insight! keep this ticket open until i commit that fix.