Comments (8)
@rvanbekkum, Thanks! That validation was are hiding in plain sight somehow 😅
I've moved this validation a bit up in the chain to early exclude procedures that are part of the interface.
from businesscentral.lintercop.
The internal method PreProcessIncomingMessage in Codeunit ESCN IC Message Order (Access = Public) is declared but never used.
from businesscentral.lintercop.
You're right, this seems like a false positive.
When a codeunit implements an interface, then LC0052 (and LC0053) should not raise a diagnostic.
from businesscentral.lintercop.
This should now be resolved in the (pre)release version of v0.30.15 of the LinterCop.
from businesscentral.lintercop.
The changes that were made are now leading to false negatives. It should not completely skip procedures in codeunits that implement an interface, because if you do that it skips procedures that are not part of the interface.
I think instead the method that checks if a procedure implements an interface procedure could/should be adjusted slightly. 😉
from businesscentral.lintercop.
@rvanbekkum , you're right, thank you for bringing this to our attention.
I need to verify if the procure is declared in the interface and then skip these.
from businesscentral.lintercop.
That's already been accounted for in the current implementation, but maybe there's an issue with the scenario in which the access modifiers of the procedures are not matching? Would need to be checked though, that's just a guess.
from businesscentral.lintercop.
Version v0.30.16 of the LinterCop is now released. Is it possible to verify of the issue is now resolved?
from businesscentral.lintercop.
Related Issues (20)
- Rule0033AppManifestRuntimeBehind - 'System.MissingMethodException' HOT 3
- Preview AL Language 14 - Unable to load Analyzer assembly HOT 6
- [LC0014] Incorrect warning, even when locked = true is set HOT 2
- LC0044 - Add support for extra transferfields from Base Application HOT 1
- AL Language Extension Version: v14.0.1002061 (pre-release) - Unhandled exception. System.InvalidCastException: Unable to cast object of type 'Microsoft.Dynamics.Nav.CodeAnalysis.Syntax.ParameterListSyntax' to type 'Microsoft.Dynamics.Nav.CodeAnalysis.Syntax.VarSectionSyntax'. HOT 3
- LC0005 doesn't work in XmlPost HOT 2
- NotBlank = TRUE is not working when you have a PK field which is based on a number series HOT 9
- [Preview] - LC0043 Unable to cast object of type 'Microsoft.Dynamics.Nav.CodeAnalysis.BoundLocal' to type 'Microsoft.Dynamics.Nav.CodeAnalysis.IConversionExpression'. (v14.0.1010940 (pre-release)) HOT 5
- LC0016 raised on extension fields where base field uses CaptionML HOT 3
- Problem/Improvement Suggestion: Unhandled Exceptions in BCLinterCop Break ALC.exe HOT 6
- [Preview ] LC0005 - System.NullReferenceException [v14.0.1010940 (pre-release)] HOT 1
- LC0039 Rule0039ArgumentDifferentTypeThenExpected HOT 3
- LC0005 Duplicate diagnostic for unlimited texts HOT 2
- No artifact available for BusinessCentral.LinterCop.AL-13.0.1027618.dll HOT 2
- InvalidCastException: 'Unable to cast object of type 'Microsoft.Dynamics.Nav.CodeAnalysis.Symbols.SourceChangeAddActionSymbol' to type 'Microsoft.Dynamics.Nav.CodeAnalysis.IActionSymbol'.' HOT 1
- BusinessCentral.LinterCop.Design.Rule0052InternalProceduresNotReferencedAnalyzer' threw an exception of type 'System.InvalidCastException'
- LC0044 false positive
- Rule0032ClearCodeunitSingleInstance' threw an exception of type 'System.InvalidCastException' HOT 3
- [Question] How to compile repository code? HOT 4
- Rule LC0054 - Interface should start with captial I - Proposal: Ignore spaces between affix and name HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from businesscentral.lintercop.