stefanpenner / es3-safe-recast

es3-safe-recast

Recasts all ECMAScript 3 reserved words to their safe alternatives.

Optionally removes trailing commas in object and array literals (pass { trailingComma: true } as the second argument to compile).

helpers

• grunt-es3-safe-recast
• gulp-dereserve
• broccoli-es3-safe-recast

Before

ajax('/asdf/1').catch(function(reason) {

}).finally(function() {

});

After

ajax('/asdf/1')['catch'](function(reason) {

})['finally'](function() {

});

Before

object = {
  catch:   function() {},
  finally: function() {},
  default: function() {}
};

After

object = {
  'catch':   function() {},
  'finally': function() {},
  'default': function() {}
};

es3-safe-recast's Issues

Enable Travis and AppVeyor to run tests.

potential issue with some syntax

I suspect an esprima issue.

the following seems to fail:

export default {
  name: 'inject-something',
  initialize: function(container, app) {
    // explode
  }
};

https://gist.github.com/amokan/3814f364cd9751e8b665

stack:

Line 3: Unexpected token :
Error: Line 3: Unexpected token :
    at throwError (/Users/stefan/tmp/foo-app/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/es3-safe-recast/node_modules/recast/node_modules/esprima/esprima.js:2073:21)
    at throwUnexpected (/Users/stefan/tmp/foo-app/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/es3-safe-recast/node_modules/recast/node_modules/esprima/esprima.js:2135:9)
    at consumeSemicolon (/Users/stefan/tmp/foo-app/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/es3-safe-recast/node_modules/recast/node_modules/esprima/esprima.js:2221:13)
    at parseStatement (/Users/stefan/tmp/foo-app/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/es3-safe-recast/node_modules/recast/node_modules/esprima/esprima.js:4063:9)
    at parseStatement (/Users/stefan/tmp/foo-app/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/es3-safe-recast/node_modules/recast/node_modules/esprima/esprima.js:4058:27)
    at parseSourceElement (/Users/stefan/tmp/foo-app/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/es3-safe-recast/node_modules/recast/node_modules/esprima/esprima.js:4584:20)
    at parseStatementList (/Users/stefan/tmp/foo-app/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/es3-safe-recast/node_modules/recast/node_modules/esprima/esprima.js:3230:25)
    at parseBlock (/Users/stefan/tmp/foo-app/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/es3-safe-recast/node_modules/recast/node_modules/esprima/esprima.js:3245:17)
    at parseStatement (/Users/stefan/tmp/foo-app/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/es3-safe-recast/node_modules/recast/node_modules/esprima/esprima.js:4000:24)
    at parseSourceElement (/Users/stefan/tmp/foo-app/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/es3-safe-recast/node_modules/recast/node_modules/esprima/esprima.js:4584:20)
    at parseProgramElement (/Users/stefan/tmp/foo-app/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/es3-safe-recast/node_modules/recast/node_modules/esprima/esprima.js:4602:16)
    at parseProgramElements (/Users/stefan/tmp/foo-app/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/es3-safe-recast/node_modules/recast/node_modules/esprima/esprima.js:4634:29)
    at parseProgram (/Users/stefan/tmp/foo-app/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/es3-safe-recast/node_modules/recast/node_modules/esprima/esprima.js:4681:16)
    at Object.parse (/Users/stefan/tmp/foo-app/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/es3-safe-recast/node_modules/recast/node_modules/esprima/esprima.js:5145:23)
    at Object.exports.parse (/Users/stefan/tmp/foo-app/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/es3-safe-recast/node_modules/recast/lib/parser.js:18:32)
    at Object.module.exports.compile (/Users/stefan/tmp/foo-app/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/es3-safe-recast/index.js:44:18)
    at ES3SafeFilter.processString (/Users/stefan/tmp/foo-app/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/index.js:23:18)
    at ES3SafeFilter.Filter.processFile (/Users/stefan/tmp/foo-app/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/broccoli-filter/index.js:135:31)
    at /Users/stefan/tmp/foo-app/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/broccoli-filter/index.js:83:21
    at tryCatch (/Users/stefan/tmp/foo-app/node_modules/ember-cli/node_modules/rsvp/dist/commonjs/rsvp/-internal.js:163:16)
    at invokeCallback (/Users/stefan/tmp/foo-app/node_modules/ember-cli/node_modules/rsvp/dist/commonjs/rsvp/-internal.js:172:17)
    at /Users/stefan/tmp/foo-app/node_modules/ember-cli/node_modules/rsvp/dist/commonjs/rsvp/promise.js:186:17
    at flush (/Users/stefan/tmp/foo-app/node_modules/ember-cli/node_modules/rsvp/dist/commonjs/rsvp/asap.js:51:9)
    at process._tickCallback (node.js:664:11)

Add 'if'?

property and member expressions must be treated differently in regex

member expression only checks must be regex checked as prop: not prop as function etc will cause any file to match and incur the costly recast step.

key:

.function

foo.
function

function:

we may just want to drop some of those crazy ones..

(cc @devinus)

this also will need to be thoroughly tested

Publish a version of this package that doesn't depend on a github version of [email protected]

I am not able to install a package that depends on es3-safe-recast because the published version of [email protected] depends on [email protected] (git+https://github.com/thomasboyt/esprima.git#4be906f1abcbb6822e33526b4bab725c6095afcd). I request that you publish a version that doesn't depend on a git repo.

old version of esprima

see: ember-cli/ember-cli#3520

Grunt support

Are there plans to create a grunt plugin for this es3 recast?
This way it is possible to run the recasting on JS files for IE8 compatibility during the build procedure.