Comments (21)
@jakearchibald this is your call, tell me what you want and I'll make it happen
from es6-promise.
+1 for this :)
from es6-promise.
Totally +1
from es6-promise.
I load polyfills as inline scripts. I would love to have a drop-in script as well.
from es6-promise.
+1 for automatic declaration
from es6-promise.
+1
from es6-promise.
+1
from es6-promise.
@stefanpenner is there a downside to this I'm not seeing?
from es6-promise.
Isn't this the way that most polyfills work?
from es6-promise.
@jakearchibald no downside I am aware. Just provide a +1 or -1 and I'll doit.
from es6-promise.
+1
from es6-promise.
+1
The polyfill should take over if !(self.Promise && !Promise.cast)
, although we should provide a way to force-overwrite for cases like subclassing.
from es6-promise.
sounds good, which evergreen browser has cast
?
from es6-promise.
Just Safari (if you count that as evergreen). It's fixed in the nightlies though.
from es6-promise.
fixed in #69
from es6-promise.
cast
is part of the specification?
How to prevent overriding the native Promise
for the latest version of Firefox and Google Chrome?
from es6-promise.
So we use es6-promise in a javascript file that's a third part script on a page. Being a 3rd party script, we never modify the host page's native objects and this change makes it impossible for us to continue using es6-promise as is.
I wanted to check with you all before I create a fork. Do you have any suggestions for my use case? Would you be open to changing the polyfill behaviour somehow? I'm not super familiar with this code base, but I wonder if you can detect if the module is require
'ed (browserify) then don't polyfill.
from es6-promise.
I wanted to check with you all before I create a fork. Do you have any suggestions for my use case? Would you be open to changing the polyfill behaviour somehow? I'm not super familiar with this code base, but I wonder if you can detect if the module is require'ed (browserify) then don't polyfill.
i don't mind shipping promise.polyfil.js (which would auto polyfil) and promise.js (which would be well behaved)
from es6-promise.
That would be really really sweet
from es6-promise.
That would be really really sweet
instead of forking, maybe you can contribute that ;)
from es6-promise.
Happy to give it a shot this weekend. Any pointers as I go through the code?
from es6-promise.
Related Issues (20)
- Intercepting `Promise.resolve` fails in `enumerator.js#L82`
- ES6Promise.Promise.prototype.finally does not behave according to spec HOT 3
- Library outdated on cdnjs
- Consider enabling the daily build in TravisCI
- The automatic polyfill fails when both 'window' and 'global' exist.
- Add `unpkg` and `jsdelivr` properties to package.json which point at dist version HOT 1
- Accessing `then` on a `function` or `object` throws within the `getThen` helper HOT 6
- Inconsistent type on `Thenable.then` overload? HOT 1
- Promise.prototype.catch IE8 Expected identifier error HOT 1
- Why are you using setTimeout(1) instead of setTimeout(0)? HOT 4
- .d.ts incompatible with TypeScript lib definitions
- ie9 catch error HOT 2
- Missing polyfill for Promise.allSettled HOT 7
- Error: 'Promise' is not exported HOT 1
- Is it required to include both scripts in html page? HOT 2
- Update CHANGELOG with 4.2.6, 4.2.7, 4.2.8?
- Switch build to Babel 7? HOT 1
- The output sequence is not consistent with native performance HOT 1
- incompatible with ie11 + babel + webpack
- Mau claim produk yang telah saya gunakan untuk konfirmasi hasil yang maksimal di perangkat Android yang telah saya mainkan verryhadisaputra
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from es6-promise.