GithubHelp home page GithubHelp logo

Comments (2)

efritze avatar efritze commented on August 20, 2024

The issue is specifically with XdrDataInputStream and XdrDataOutputStream. Looking at the code, these classes handle only "US-ASCII" characters.

Below are some more specific tests I did.

 //helper for tests below.
    public static String backAndForthXdrStreaming(String inputString) throws IOException {

        //String to XDR
        ByteArrayOutputStream byteOutputStream = new ByteArrayOutputStream();
        XdrDataOutputStream xdrOutputStream = new XdrDataOutputStream(byteOutputStream);
        xdrOutputStream.writeString(inputString);

        byte[] xdrByteOutput = byteOutputStream.toByteArray();

        //XDR back to String
        XdrDataInputStream xdrInputStream = new XdrDataInputStream(new ByteArrayInputStream(xdrByteOutput));
        String outputString = xdrInputStream.readString();

        return outputString;

    }

    @Test
    public void backAndForthXdrStreamingWithStandardAscii() throws IOException {
        //this works. The $ sign is part of the standard US-ASCII character set.
        String memo = "Dollar Sign $";
        assertEquals(memo, backAndForthXdrStreaming(memo));

    }

    @Test
    public void backAndForthXdrStreamingWithNonStandardAscii() throws IOException {
        //this  doesn't works. The € sign is NOT part of the standard US-ASCII character set.
        String memo = "Euro Sign €";
        assertEquals(memo, backAndForthXdrStreaming(memo));

    }

from java-stellar-sdk.

efritze avatar efritze commented on August 20, 2024

I created a pull request which fixes this issue. #51 .

from java-stellar-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.