GithubHelp home page GithubHelp logo

Comments (4)

Stephanevg avatar Stephanevg commented on May 10, 2024

In my eyes, if it is already in the HostsFile, then we should throw an exception. (or minimal would be a warning message.

If it is creating an entry using one of the constructors of [HostsEntry], It should throw an error, definitley.
This functionality is actually already in the this class if I am not mistaken. By casting it to [IpAddress] it will not allow you to set an invalid Ip address as showed below:

image
Is that what you had in mind?

from hostsfilemanagement.

Stephanevg avatar Stephanevg commented on May 10, 2024

I added two new tests here -> 22500f9 That actually tests that it correctly throws an error when a wrong type of IP address is passed to the constructor of [HostsEntry].

from hostsfilemanagement.

irwins avatar irwins commented on May 10, 2024

In my eyes, if it is already in the Hosts File, then we should throw an exception. (or minimal would be a warning message.
Good one! The host file can still be edited manually with invalid data. You could also use it to parse if the Hosts file is valid and re-mediate any issues found.

from hostsfilemanagement.

Stephanevg avatar Stephanevg commented on May 10, 2024

I'll close this issue since the error handling on the IPAddress type is already handled through the Casting to [IpAddress].

from hostsfilemanagement.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.