CurrencyID should not be present about zugferd-csharp

[pkurz]

Thanks for pushing the commit, but it seems that i still get the same errors.

[stephanstapel]

Can you provide an example (source code/ ZUGFeRD file)?

[pkurz]

Sorry for late response, here is an example file:
zugferd.zip

[stephan-nowecor]

is it possible that you provide the source code as well?

[pkurz]

        private InvoiceDescriptor CreateInvoice(InvoiceMetadataModel metadata)
        {
            InvoiceDescriptor desc = InvoiceDescriptor.CreateInvoice(metadata.ReferenceNumber, metadata.InvoiceDate, CurrencyCodes.EUR);
            desc.Profile = Profile.Comfort;
            desc.AddNote($"Rechnung {metadata.ReferenceNumber} vom {metadata.InvoiceDate}.");
            desc.SetBuyer(metadata.BuyerInformation.Name1, metadata.BuyerInformation.Plz, metadata.BuyerInformation.Ort, metadata.BuyerInformation.Strasse, CountryCodes.DE, "");
            desc.AddBuyerTaxRegistration("DE1234567890", TaxRegistrationSchemeID.VA);
            desc.SetSeller(metadata.CompanyModel.Name1, metadata.CompanyModel.Plz, metadata.CompanyModel.Ort, metadata.CompanyModel.Strasse, CountryCodes.DE, metadata.CompanyModel.Id.Value, new GlobalID(GlobalID.SchemeID_GLN, "4000001123452"));
            desc.AddSellerTaxRegistration(metadata.CompanyModel.Steuernummer, TaxRegistrationSchemeID.VA);
            desc.addTradeLineItem("Rechnungsbetrag", "", QuantityCodes.LS, 1, metadata.GrossValue, metadata.NetValue, 1, TaxTypes.VAT, TaxCategoryCodes.S,
                metadata.TaxPercent);
            desc.SetTotals(lineTotalAmount: metadata.NetValue, taxBasisAmount: metadata.NetValue, taxTotalAmount: metadata.TaxTotal, grandTotalAmount: metadata.GrossValue, duePayableAmount: metadata.GrossValue);
            desc.AddApplicableTradeTax(metadata.NetValue, metadata.TaxPercent, TaxTypes.VAT, TaxCategoryCodes.S);
            desc.SetTradePaymentTerms($"Zahlbar innerhalb {(metadata.DueDate - metadata.InvoiceDate).TotalDays} Tagen netto bis {metadata.DueDate}", metadata.DueDate);
            

            return desc;
        }

the InvoiceMetadataModel has basic properties from what you'd expect (mostly strings and datetimes).

[stephanstapel]

It works with the latest code. I tested:
version 2.1, profiles basic, comfort (no currency), extended (currency).

Could you checkout the latest code and test it again?

[pkurz]

It works with the latest code. I tested:
version 2.1, profiles basic, comfort (no currency), extended (currency).

Could you checkout the latest code and test it again?

Yes it works with the newest version.
Now I get a weird error, which i can't resolve. I'll open another issue for this.

[stephanstapel]

I'll close this issue.