GithubHelp home page GithubHelp logo

Comments (6)

stephenh avatar stephenh commented on June 15, 2024 1

@ws-gregm huh, we did just ship #1027 cc @dasco144 , but I don't think importing Rpc from ts-proto was really working on purpose, previously.

I.e. the ts-proto package is meant to be "the code generator you run at build-time" and not really the "the runtime code / dependency your app uses to encode/decode data".

I.e. we should be generating a interface Rpc into the output of ts-proto, so that when you package up the AuthorMessage / BookMessage / etc messages, the interface Rpc type should be included in that.

So, dunno, I'm curious to learn if/how this was actually working before, but I think it's intended that you import Rpc from the ts-proto-generated code and not the ts-proto dependency itself.

from ts-proto.

ws-gregm avatar ws-gregm commented on June 15, 2024

Hey @stephenh thanks so much for getting back so quickly. Do you have an example of what this would look like or how I would use this?

so that when you package up the AuthorMessage / BookMessage / etc messages, the interface Rpc type should be included in that

from ts-proto.

stephenh avatar stephenh commented on June 15, 2024

Hi @ws-gregm , sorry, an example of what? For better or worse, going through ts-proto's integration/ directory and looking for usages that are most similar to what you're trying to do is the best bet.

from ts-proto.

ws-gregm avatar ws-gregm commented on June 15, 2024

@stephenh Digging through there - it's not clear to me how to

  1. instantiate a grpc client
  2. Specify ip and port to grpc server

from ts-proto.

stephenh avatar stephenh commented on June 15, 2024

@ws-gregm if you're using grpc-js, this example is probably a good one to copy/paste from:

https://github.com/stephenh/ts-proto/blob/main/integration/grpc-js/grpc-js-test.ts#L152

I'm going to close this issue out b/c I don't think it's related to a breaking change in the exports. If you'd like to submit any PRs to improve the docs for ^, that'd be great, thanks!

from ts-proto.

ws-gregm avatar ws-gregm commented on June 15, 2024

Hey @stephenh, maybe it's best if I open a discussion but responding here for context. I experimented with TestClient. It appears that TestClient doesn't include methods that return promises. Meanwhile, the benefit of the generated *ClientImpl classes is that they return promises.. To use the *ClientImpl, I would need to craft this mystical rpc object. There doesn't appear to be any obvious guidance on this matter in the tests. From my POV, the general aim is to drive generated client methods that return promises. What's the typical way to do this? Also, I eventually need to expose methods that return a stream. I tried combing through existing projects that use ts-proto and I'm not find clear guidance there either.

from ts-proto.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.