GithubHelp home page GithubHelp logo

Comments (5)

oliveryasuna avatar oliveryasuna commented on September 27, 2024

@stephenh #1070

from ts-proto.

stephenh avatar stephenh commented on September 27, 2024

Hi @oliveryasuna ; just checking, but what do you mean by isolated builds?

Initially I would have guessed that we should just have index.ts output the type registry, if both options are enabled, without needing a new option.

from ts-proto.

oliveryasuna avatar oliveryasuna commented on September 27, 2024

@stephenh Honestly, I have no idea what I meant by "isolated builds" when I wrote that late last night. Maybe I meant that the generated TS files could be in their own package, and some developers will write their own type registry instead of using the generated one. Therefore, by adding the type registry to the the exports by default, it could introduce namespace conflicts, hence could be viewed as a breaking change.

from ts-proto.

stephenh avatar stephenh commented on September 27, 2024

Ah yeah; you're right that it's a change in behavior, but dunno, personally I don't think a new symbol being exported from index.ts is a breaking change (vs. a previously-exported symbol now becoming non-exported, which ofc is a breaking change).

So, given that, are you fine with updating your PR to not introduce a new options.exportTypeRegistry option, and instead just use the existing outputIndex=true + outputTypeRegistry=true settings to add the additional export?

Thanks!

from ts-proto.

oliveryasuna avatar oliveryasuna commented on September 27, 2024

@stephenh Either perspective is valid. My concern is an edge edge edge case. Yes, I will update my PR!

from ts-proto.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.