Comments (5)
from ts-proto.
Hi @oliveryasuna ; just checking, but what do you mean by isolated builds?
Initially I would have guessed that we should just have index.ts
output the type registry, if both options are enabled, without needing a new option.
from ts-proto.
@stephenh Honestly, I have no idea what I meant by "isolated builds" when I wrote that late last night. Maybe I meant that the generated TS files could be in their own package, and some developers will write their own type registry instead of using the generated one. Therefore, by adding the type registry to the the exports by default, it could introduce namespace conflicts, hence could be viewed as a breaking change.
from ts-proto.
Ah yeah; you're right that it's a change in behavior, but dunno, personally I don't think a new symbol being exported from index.ts
is a breaking change (vs. a previously-exported symbol now becoming non-exported, which ofc is a breaking change).
So, given that, are you fine with updating your PR to not introduce a new options.exportTypeRegistry
option, and instead just use the existing outputIndex=true
+ outputTypeRegistry=true
settings to add the additional export?
Thanks!
from ts-proto.
@stephenh Either perspective is valid. My concern is an edge edge edge case. Yes, I will update my PR!
from ts-proto.
Related Issues (20)
- Consider switching many types to interfaces HOT 2
- Incorrect message names in the generated code for repeated fields HOT 2
- `nestJs=true` and `useDate=true` interferes with `@google-cloud/firestore` HOT 1
- runing cmd 'protoc' in the bash script will miss some files HOT 2
- `nestJs=true` incorrect type generation for proto fields with numbers
- Adding Explicit Type Definitions to Factory Method Objects HOT 6
- Unclear documentation for a NestJS stream handling HOT 1
- grpc client receive date wrong with grpc server create by nestjs and type orm HOT 2
- Feature Request: add options to limit generating encode and decode methods to only specific message types HOT 2
- Bug in toJSON Function with `removeEnumPrefix=true` and `unrecognizedEnumValue=0` Option Combination HOT 2
- feat: Provide configuration via file HOT 2
- docs: make a table of all available arguments in readme HOT 5
- protoc-gen-ts_proto no longer points to the correct plugin location in version 2.0.0 HOT 7
- When properties of an object are empty, empty buffer is returned from encode() HOT 2
- v2.0.2 missing package.json HOT 3
- Protoc throwing "basic_string::_M_construct null not valid" when trying to generate types HOT 1
- Significant Performance Regression in ts-proto v2 Compared to v1 HOT 6
- Feature request: virtual oneof property HOT 2
- When tagging exportCommonSymbols: true should export services
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ts-proto.