stephenmhall / piheating Goto Github PK

webui.py got

self.switchHeat()
File "H:/src/PiHeating/PiHeating\max.py", line 486, in switchHeat
roomTemps = CreateUIPage().createRooms()
File "H:/src/PiHeating/PiHeating\webui.py", line 215, in createRooms
actualTemp = goodTemps[roomText]
KeyError: u'Utility Room'

fixed this by changing line 215 from

actualTemp = goodTemps[roomText]
to
actualTemp = goodTemps.get(roomText, 0)

Hey Stephen

After a long break I finally got around to forking your code (via twistedsanity) and I have a couple of questions

1. Why do you generate a static file for the website? The only reason I can think of doing this is to reduce the load on querying the MaxCube, but the code is kinda hard to read. Im not a python programmer (more java/node) but this looks like a strange thing to do.. that said it will perform nicely.. Just wondering why you did it this way

2. I noticed you store initialization variables AND runtime data in variables.txt.. Why? I would have thought an init.properties file and a seperate runtime data file would be better.. or store it in the local DB... Curious to why

otherwise thanks for the head start!

I plan to use this code but without a Vera system, I was thinking it might be good to have a flag, like useVera=true|false, and whenever we call out to a vera device we check to see if the flag is set.

I dont plan to use a vera, will use direct relay and thinking this might make it more generic

Im running the code on my windows box (for now till I get a relay for the PI) and have noticed I get the following error when saving a temperature to a valve. The valve however does get the new temperature

BaseHTTPRequestHandler.__init__(self, request, client_address, server)

File "C:\Python27\lib\SocketServer.py", line 652, in init
self.handle()
File "C:\Python27\lib\BaseHTTPServer.py", line 340, in handle
self.handle_one_request()
File "C:\Python27\lib\BaseHTTPServer.py", line 328, in handle_one_request
method()
File "H:/src/PiHeating/PiHeating\requesthandler.py", line 72, in do_GET
SendMessage().updateRoom(roomData)
File "H:/src/PiHeating/PiHeating\sendmessage.py", line 191, in updateRoom
CreateUIPage().updateWebUI()
File "H:/src/PiHeating/PiHeating\webui.py", line 23, in updateWebUI
self.saveAdminUI()
AttributeError: CreateUIPage instance has no attribute 'saveAdminUI'

going through the code I noticed that manual boiler switch is commeted out in both max.py and heatinggpio.py, just wondering why? its controlled by flags