[jira] Consider exposing tls/host for jira as common variables about helm-charts

[stevehipwell]

Sorry for the slow reply, I've been AFK. Setting env as you've shown would be the correct way to do this. Like much of the community I'm not a fan of the Traefik CRD design, specifically around it not being idiomatic, so while I try and make it possible to use I wont ruin the chart UX to make it first class. AFIK Traefik v2 has ingress support so I'd suggest using that if you want an Idiomatic pattern.

[EugenMayer]

No need to excuse here - you have time or you do not. I'am very happy to be able to use all your work, taking your times for comments is just - if possible or just not :)

I will not argue with you on the CRD part since i'am sure it is not important (and I would agree to disagree - I has huge pros). I do no think we need to convince ourselves here though, it's fine to have a different understanding.

I think for Atlassian Products you should always care about the 3 settings here, not matter which ingress is used or not. I think the extra complexity added to just not use your build-in ingress but anything else.

Just to be sure, it is not solving it for us, not asking you to fix anything we might "run into since we run some special sort of thing" - it works for us the way it is.

My intention is to improve it in general. Generally speaking, you have put the domain into the area of "ingress only". As for other applications also, but every especially for each atlassian product, the application needs to know about the domain and scheme very well. So pull the property of TLS/Domain up and the use it on places needed seems to be the better way to deal with it.

If you think it is not worth the effort or similar, just close the issue, I'm totally fine with that

[stevehipwell]

@EugenMayer thanks for opening this but I'm happy with the current design. All my charts follow a Kubernetes idiomatic design and the hosts are under the ingress section as that the idiomatic Kubernetes way to expose services. I think moving the hosts would be detrimental to the expected use of this chart and would increase cognitive complexity for most people. The host settings wont ever be set in two places in the values file (if they were YAML anchors could help), for idiomatic use they're under ingress and for non-standard solutions you can set them in the env.