GithubHelp home page GithubHelp logo

Comments (2)

diegocr avatar diegocr commented on June 1, 2024

Hi, the changes you're suggesting are for the function detectVerticalSquash which is not used for PNG files, only for image/jpeg ones (see #18)

However, playing with the image http://i.imgur.com/lxfQQqa.png as pointed in dropzone/dropzone#813 I was able to reproduce the stretch problem, which is being caused here from the detectSubsampling function, that one is indeed used for any image.

For the sake of, i tried to apply the same kind of fix:

return ctx.getImageData(0, 0, 1, 1).data[3] === 0;

to this:

return ctx.getImageData(1, 0, 1, 1).data[3] === 0;

but it doesn't seems to fix the problem, kinda odd.

from ios-imagefile-megapixel.

zulalay avatar zulalay commented on June 1, 2024

in my case as well detectVerticalSquash function is called from renderImageToCanvas() method

i fixed it by commenting out some code
var alpha = data[(py - 1) * 4 + 3];
//if (alpha === 0) { //that fixes issue when it cant save png with transparent screen
// ey = py;
//} else {
sy = py;
//}
didnt find any bad influence yet but needs more testing :)

from ios-imagefile-megapixel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.