GithubHelp home page GithubHelp logo

Comments (4)

marbemac avatar marbemac commented on May 28, 2024

Interesting, could you provide the before and after swagger's separately, perhaps in a couple of linked gists?

One thing I noticed right off the bat is that the original swagger is not valid - the "host" property should have the actual host, not the protocol. And the "basePath" property should not have the host, it should have a relative path or nothing.

from api-spec-converter.

glodieu avatar glodieu commented on May 28, 2024

Hi Marc, I'm attaching before.json and after.json.
Regarding host and baseHost... such file is hosted in mulesoft/api-spec-converter repo (https://github.com/mulesoft/api-spec-converter/blob/master/example/source/swagger.json) I'll talk with Christian Vogel about this.
Thanks a lot for you help!
Gaston

before.json.txt
after.json.txt

from api-spec-converter.

glodieu avatar glodieu commented on May 28, 2024

Hi Marc,
File that we're mentioned is hosted in this repository https://github.com/stoplightio/api-spec-converter/blob/master/example/source/swagger.json
Thanks.
Gaston

from api-spec-converter.

marbemac avatar marbemac commented on May 28, 2024

OH I read that as a diff of the input swagger to output swagger, not as a test result, whoops! We will take a look, thanks for pointing this out.

from api-spec-converter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.