GithubHelp home page GithubHelp logo

Comments (5)

marcelltoth avatar marcelltoth commented on August 10, 2024 1

We are working on that, too.:)

from json-schema-viewer.

marbemac avatar marbemac commented on August 10, 2024 1

Pretty sure just need to remove the hardcoded backgroundColor style (relic of v3?) https://github.com/stoplightio/json-schema-viewer/blob/beta/src/components/shared/Validations.tsx#L189 and add sl-canvas-50 class.

from json-schema-viewer.

Fox32 avatar Fox32 commented on August 10, 2024

The fix would probably touch https://github.com/stoplightio/json-schema-viewer/blob/beta/src/components/shared/Validations.tsx#L189, but I'm not sure which is the right color value to use here.

from json-schema-viewer.

marcelltoth avatar marcelltoth commented on August 10, 2024

Hey @Fox32 ! Thanks for pointing out the issue!

We'll be looking into this as soon as we enable dark mode support within our own platform. In the meanwhile if you find a way to fix it, we appreciate any pull requests.

from json-schema-viewer.

Fox32 avatar Fox32 commented on August 10, 2024

I think using a base color and applying it with opacity might be handy here. That way it could work with both light and dark mode.

I can't make any promises about creating a PR for it though. Right now I'm stuck at integrating the package as I run into issues with existing CSS in my app.

from json-schema-viewer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.