Comments (2)
Pretty exciting! I'd say let's do this in two steps:
- Update the docs
- Update the preset after we've gotten some feedback
What do you think?
from presets.
When I do that, there's an error:
border: 1px solid black
^
Expected newline.
Grawl/storybook-craco-example@4bcc084
/Users/daniilpronin/.nvm/versions/node/v12.16.2/bin/node /Users/daniilpronin/.nvm/versions/node/v12.16.2/lib/node_modules/yarn/bin/yarn.js run storybook
yarn run v1.22.4
$ start-storybook -p 9009 -s public
info @storybook/react v5.3.18
info
info => Loading static files from: /Users/daniilpronin/Sites/uibook-craco-example/public .
info => Loading presets
info => Loading presets
info => Adding stories defined in ".storybook/main.js".
WARN `@storybook/preset-scss` may not be compatible with `@storybook/preset-create-react-app`
info => Loading Webpack configuration from `node_modules/react-scripts`
info => Removing existing JavaScript and TypeScript rules.
info => Modifying Create React App rules.
info => Using default Webpack setup.
webpack built 6cac0f9e919cbce34225 in 6042ms
✖ 「wdm」: Hash: 6cac0f9e919cbce34225
Version: webpack 4.43.0
Time: 6042ms
Built at: 05/13/2020 8:03:24 PM
Asset Size Chunks Chunk Names
asset-manifest.json 472 bytes [emitted]
iframe.html 2.87 KiB [emitted]
main.6cac0f9e919cbce34225.bundle.js 17.9 KiB main [emitted] [immutable] main
main.6cac0f9e919cbce34225.bundle.js.map 5.71 KiB main [emitted] [dev] main
runtime~main.6cac0f9e919cbce34225.bundle.js 33.5 KiB runtime~main [emitted] [immutable] runtime~main
runtime~main.6cac0f9e919cbce34225.bundle.js.map 34.7 KiB runtime~main [emitted] [dev] runtime~main
vendors~main.6cac0f9e919cbce34225.bundle.js 2.34 MiB vendors~main [emitted] [immutable] [big] vendors~main
vendors~main.6cac0f9e919cbce34225.bundle.js.map 2.37 MiB vendors~main [emitted] [dev] vendors~main
Entrypoint main [big] = runtime~main.6cac0f9e919cbce34225.bundle.js runtime~main.6cac0f9e919cbce34225.bundle.js.map vendors~main.6cac0f9e919cbce34225.bundle.js vendors~main.6cac0f9e919cbce34225.bundle.js.map main.6cac0f9e919cbce34225.bundle.js main.6cac0f9e919cbce34225.bundle.js.map
[0] multi ./node_modules/@storybook/core/dist/server/common/polyfills.js ./node_modules/@storybook/core/dist/server/preview/globals.js ./.storybook/generated-entry.js ./node_modules/webpack-hot-middleware/client.js?reload=true&quiet=true 64 bytes {main} [built]
[./.storybook/generated-entry.js] 227 bytes {main} [built]
[./node_modules/@storybook/core/dist/server/common/polyfills.js] 120 bytes {vendors~main} [built]
[./node_modules/@storybook/core/dist/server/preview/globals.js] 93 bytes {vendors~main} [built]
[./node_modules/@storybook/core/node_modules/webpack/buildin/harmony-module.js] (webpack)/buildin/harmony-module.js 573 bytes {vendors~main} [built]
[./node_modules/@storybook/core/node_modules/webpack/buildin/module.js] (webpack)/buildin/module.js 497 bytes {vendors~main} [built]
[./node_modules/@storybook/react/dist/client/index.js] 1.34 KiB {vendors~main} [built]
[./node_modules/airbnb-js-shims/index.js] 40 bytes {vendors~main} [built]
[./node_modules/core-js/features/symbol/index.js] 359 bytes {vendors~main} [built]
[./node_modules/global/window.js] 232 bytes {vendors~main} [built]
[./node_modules/querystring-es3/index.js] 127 bytes {vendors~main} [built]
[./node_modules/regenerator-runtime/runtime.js] 23.6 KiB {vendors~main} [built]
[./node_modules/webpack-hot-middleware/client-overlay.js] 2.17 KiB {vendors~main} [built]
[./node_modules/webpack-hot-middleware/client.js?reload=true&quiet=true] 7.68 KiB {vendors~main} [built]
[./node_modules/webpack-hot-middleware/node_modules/strip-ansi/index.js] 161 bytes {vendors~main} [built]
+ 640 hidden modules
ERROR in ./src/components/button.sass (./node_modules/css-loader/dist/cjs.js!./node_modules/sass-loader/lib/loader.js??ref--5-2!./node_modules/style-loader!./node_modules/css-loader/dist/cjs.js??ref--8-oneOf-5-1!./node_modules/postcss-loader/src??postcss!./node_modules/sass-loader/lib/loader.js??ref--8-oneOf-5-3!./src/components/button.sass)
Module build failed (from ./node_modules/sass-loader/lib/loader.js):
border: 1px solid black
^
Expected newline.
╷
2 │ var content = require("!!../../node_modules/css-loader/dist/cjs.js??ref--8-oneOf-5-1!../../node_modules/postcss-loader/src/index.js??postcss!../../node_modules/sass-loader/lib/loader.js??ref--8-oneOf-5-3!./button.sass");
│ ^
╵
stdin 2:220 root stylesheet
in /Users/daniilpronin/Sites/uibook-craco-example/src/components/button.sass (line 2, column 220)
@ ./src/components/button.sass 2:14-357 21:1-42:3 22:19-362
@ ./src/components/button.jsx
@ ./src/stories/1-Button.stories.js
@ ./src sync ^\.\/(?:(?:(?!\.)(?:(?:(?!(?:|\/)\.).)*?)\/)?(?!\.)(?=.)[^/]*?\.stories\.js\/?)$
@ ./.storybook/generated-entry.js
@ multi ./node_modules/@storybook/core/dist/server/common/polyfills.js ./node_modules/@storybook/core/dist/server/preview/globals.js ./.storybook/generated-entry.js ./node_modules/webpack-hot-middleware/client.js?reload=true&quiet=true
Child HtmlWebpackCompiler:
Asset Size Chunks Chunk Names
__child-HtmlWebpackPlugin_0 6.48 KiB HtmlWebpackPlugin_0 HtmlWebpackPlugin_0
Entrypoint HtmlWebpackPlugin_0 = __child-HtmlWebpackPlugin_0
[./node_modules/@storybook/core/node_modules/html-webpack-plugin/lib/loader.js!./node_modules/@storybook/core/dist/server/templates/index.ejs] 2.13 KiB {HtmlWebpackPlugin_0} [built]
WARN Broken build, fix the error above.
WARN You may need to refresh the browser.
from presets.
Related Issues (20)
- [Bug] CRA does not print eslint errors to terminal anylonger
- [Bug] CRA preset does not support ES2020 dependencies HOT 2
- Where are the tests for your presets?
- V3.2.0 works but V4.0.0 does not HOT 4
- [Bug] preset-create-react-app: Storybook config dir webpack override breaks default CRA config
- [Bug] Install @storybook/preset-scss with default storybook's bundler 'webpack4' doesn't works HOT 5
- [Bug] CRA5, [email protected] HOT 6
- [Bug] Fails in case of using custom folder structure inside /src
- [Help] Cannot find module '@babel/plugin-proposal-private-property-in-object'
- @storybook/preset-create-react-app 4.0.1 breaks Storybook HOT 4
- [Bug]: macos - Error: Cannot find module '.../node_modules/config/webpack.config' HOT 5
- [Bug] URL from readme does not exist on the website
- [Bug] ENAMETOOLONG on "preset-create-react-app@4" package installation HOT 1
- [Bug] start-storybook breaks when tsconfig.json has comments (preset-create-react-app)
- [Bug] Package dependency HOT 4
- [Bug] Confusing error message when stories folder is outside of src.
- [Bug] cannot run storybook with CRA preset version 4.1.0. HOT 1
- @storybook/react-docgen-typescript-plugin canary dependency
- [Bug] Storybook preset function `getReactScriptsPath` has bug HOT 2
- Missing license file
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from presets.