GithubHelp home page GithubHelp logo

Comments (8)

mrmckeb avatar mrmckeb commented on July 17, 2024 1

OK, will look tonight if possible!

from presets.

shilman avatar shilman commented on July 17, 2024

Here's how it's handled in the built-in preset:

storybookjs/storybook@51c9b2a

from presets.

shilman avatar shilman commented on July 17, 2024

Can confirm that Storybook changes, presumably those in storybookjs/storybook#9075 have broken the preset, both in Triconfig mode (main.js) and ALSO in traditional configuration mode (config.js/presets.js).

To reproduce:

  1. Follow instructions in https://gist.github.com/shilman/bc9cbedb2a7efb5ec6710337cbd20c0c
  2. Observe no prop tables
  3. Run with --debug-webpack to show that no TS loader was added
  4. Downgrade to 5.3.0-beta.16 and re-run, observe prop tables

from presets.

mrmckeb avatar mrmckeb commented on July 17, 2024

Thanks @shilman, I can take a look at this over this week - alongside the cleanup/quality work.

This is going to be part of 5.3.0?

from presets.

shilman avatar shilman commented on July 17, 2024

@mrmckeb Thank you! It's already part of 5.3 and breaking users since beta.16 😁

from presets.

danfinch100 avatar danfinch100 commented on July 17, 2024

Hi - I tried downgrading to 5.3.0-beta.16 but still can't see the props. Could you post a basic package.json with the last stable (non-beta) version where this is working? Even better would be a starter project where the configuration (i.e. Tri config or traditional) is clear. Thanks

from presets.

shilman avatar shilman commented on July 17, 2024

@danfinch100 follow this with beta.15 or below: https://gist.github.com/shilman/bc9cbedb2a7efb5ec6710337cbd20c0c

from presets.

danfinch100 avatar danfinch100 commented on July 17, 2024

Great, that works - thanks. Also, should point out that the comments i.e. 'The world's most basic button' weren't working either but are with beta.15 ... thats both:

npx -p @storybook/[email protected] sb init --story-format=csf-ts

and

yarn add @storybook/[email protected] --dev

from presets.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.