EXTEND_ESLINT=true breaks linting (typescript?) about presets

[jookshub]

@mrmckeb Here is a small reproduction. https://github.com/jookshub/storybook_cra_tsx/tree/demo-eslint-issue%2387

Without EXTEND_ESLINT Storybook is using its own eslint rule set.

Is there any guide on how to setup Storybook 6 with an CRA & TypeScript project that uses its own esLint config?

[josias-r]

@mrmckeb
Sorry, I'm working in quite a large project, but here are my versions:

@storybook/* : ^5.3.9
@storybook/preset-create-react-app: ^1.5.2
react-scripts: ^3.3.1
react: ^16.12.0
typescript: ^3.7.5

In my .env file I only have the extend eslint option set.

Take a look at the issue I mentioned above. Turns out the errors I'm getting are coming from a react-docgen installation that isn't configured for typescript. This still doesn't explain this though:

I just don't understand why react-docgen errors appear only after I added EXTEND_ESLINT=true. I don't see a connection between eslint and react-docgen 🤔

[josias-r]

I just discovered something weird. I opened this issue, which causes react-docgen to fail.

Turns out, all the errors I'm getting after setting the env variable, are coming from react-docgen in advanced use cases w/ typescript.

I just don't understand why react-docgen errors appear only after I added EXTEND_ESLINT=true. I don't see a connection between eslint and react-docgen 🤔

[mrmckeb]

Hey @josias-r, are you able to provide a reproduction repo? Or if not, at least version of packages and configuration details? Thanks!

[mrmckeb]

I think it would help if you could share a very small reproduction - it doesn't have to contain anything but a copy of your config and one simple story to show this error.

I can then properly investigate and propose a fix.

I assume - but could be wrong - that it is something to do with the way ESLint is handling TS/JS files as you suggested.

[mrmckeb]

And sorry for the very slow response, I was away on a business trip that was much busier than expected.