Clarification of documentation about handling errors about raw-body

[dougwilson]

Hi @misos1 I'm not sure where Node.js write this in their docs, but this is where the magic happens internally to read off the rest of the request stream: https://github.com/nodejs/node/blob/master/lib/_http_server.js#L807-L811 . What version of Node.js are you using? I wonder if there has been a change in behavior (on purpose or accidentally). As for Express, that supports all the way down to Ndoe.js 0.10, which doesn't have that behavior.

[misos1]

v15.12.0 on darwin.

[misos1]

I think this comment makes sense. "raw-body" probably already started reading so this does not apply.

// If the user never called req.read(), and didn't pipe() or
// .resume() or .on('data'), then we call req._dump() so that the
// bytes will be pulled off the wire.

[dougwilson]

Well, their comment assumes that it didn't stop reading. If you look at the properties it checks, it is checking for active read, which was undone by this module.

[dougwilson]

I am taking a look to see what is happening. It may be just that the docs need to be changed.

[misos1]

Ok, also same behaviour on linux with node v14.16.0.

[dougwilson]

It looks like it changed with nodejs/node@3d480dc where it will never dump once it was started reading.

[misos1]

req._consuming is true inside my error handler.

[dougwilson]

Right, because you can see in that Node.js commit, it will only ever set it to true on the first read. There is no logic to set it back to false like there is with the readablestate property it was using before that change.

[misos1]

Also there is typo in this sentence "The errors from this module have a type property which allows for the progamatic determination of the type of error returned.".

[dougwilson]

Can you clarify what the typo is and/or make a PR?

[misos1]

I think "progamatic" should be something else. (Just to note as I suppose that docs will be updated anyway.)

[dougwilson]

Ah, gotcha. What should it be instead? I can make the update if you don't want to, just need to know what you're looking to change.

[misos1]

Is needed any more info?