Comments (5)
I'll take this one
from streetsupport-web.
Just a quick update: I've managed to get this working on my branch cec4100 but it's broken the search unit tests, so I need to work out how to fix those before I can put in the pull request.
from streetsupport-web.
@mikecoram - you should be able to just delete the failing tests, and copy and amend the existing ones for the listing (spec\find-help\all-organisations\HappyPathSpec.js). the main tests are that it:
- on search, it makes the correct request with expected querystring to the API
- it replaces any previously retrieved items by the results of the search
- the load more still works, should there be more than size items that match the search query
from streetsupport-web.
My apologies, I haven't managed to finish this and can't make it tonight.
Anyone should feel free to pick this up, my changes are here: https://github.com/mikecoram/streetsupport-web/tree/search-by-name
from streetsupport-web.
thanks @mikecoram. i've merged that in and fixed the test.
from streetsupport-web.
Related Issues (20)
- extract find organisations form from location homepages into partial
- When hovering over green nav item, then into its child nav, retain dark green background of parent item HOT 2
- create task/build step to create sitemap.xml
- create sitemap page
- move nav link HOT 1
- generate /find-help/ html page in build process HOT 1
- add content security policy
- new organisations print friendly view
- fix horizontal scroll in mobile view HOT 2
- Add link to Bournemouth JustGiving page, from bournemouth nav HOT 1
- rochdale real change in mobile has the incorrect title image HOT 1
- add browserstack tests to CI in travis HOT 2
- create js plugin for organisations to display their needs
- Spike PWA'ing the site HOT 1
- Fix various FOUC instances across the site (criticalcss)
- Accessibility Improvements HOT 2
- list.fuzzysearch.js breaks second npm install
- build core test suite
- Crypto for the homeless HOT 1
- Chico, Ca HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from streetsupport-web.