GithubHelp home page GithubHelp logo

Comments (6)

sam-github avatar sam-github commented on July 20, 2024

Can you make npm pack bundle your deps? If not, its an npm bug, or a scoped package misfeature. Do you have an example I could run?

from strong-build.

sam-github avatar sam-github commented on July 20, 2024

Or can I at least have a copy of your package.json?

from strong-build.

barwin avatar barwin commented on July 20, 2024

Hi @sam-github

Sure, here is a copy of my package.json:

{
  "name": "@ylopo/geocoder",
  "version": "0.2.0",
  "description": "Testing scoped dependencies.",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1",
    "start": "node ."
  },
  "author": "Some Guy",
  "license": "None",
  "dependencies": {
    "@ylopo/service-logger": "^1.3.0",
    "MD5": "^1.2.1"
  },
  "devDependencies": {
    "grunt": "^0.4.5",
    "grunt-contrib-jshint": "^0.10.0"
  },
  "bundleDependencies": [
    "@ylopo/service-logger",
    "MD5"
  ]
}

After an slc build -b -p, the resulting .tgz file does have MD5 bundled, but it does not have the @ylopo/service-logger module.

Edit: I could not make npm pack bundle my deps .. so it sounds like it's an issue with npm. I still would appreciate a sanity check that my package.json looks like it should work before I take it up with npm.

Thanks for taking a look at this,

-Ben

from strong-build.

sam-github avatar sam-github commented on July 20, 2024

We call npm pack... so my opinion isn't worth much!

That said, you look like you are following the rules, your top-level package is scoped, and your deps are scoped.

from strong-build.

cgole avatar cgole commented on July 20, 2024

@sam-github, does this need to be open? Any action required from our side.

from strong-build.

sam-github avatar sam-github commented on July 20, 2024

We could rewrite packing to not rely on npm, but other than that, we are blocked on npm fixing npm/npm#8614, this is a known bug.

from strong-build.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.