If charon is dead, the vici session cannot be closed. about govici

[mmellison]

Can you confirm the version of the library you are using?

This looks to be the same as #24 (which was fixed in #25).
If you are not using 0.4.1 or newer, I would suggest upgrading and seeing if the issue persists.

[enr0n]

Seeing as this sample code uses Session.Listen, which was changed to Subscribe in v0.4.0, the fix for this (c46d911) is not in your version of the package.

Please upgrade to at least v0.4.1 as @seglberg suggested.

[weixiaolan2019]

Thank you, I get it.

[weixiaolan2019]

I have another issue, this is the code:

func (t *transport) recv() (*packet, error) {
buf := make([]byte, headerLength)
t.conn.SetReadDeadline(time.Now().Add(time.Second * 20))
_, err := t.conn.Read(buf)
if err != nil {
if ne, ok := err.(net.Error); ok && ne.Timeout() {
return nil, ne
}
return nil, fmt.Errorf("%v: %v", errTransport, err)
}

================================================================
pl := binary.BigEndian.Uint32(buf)
//netbank.cn
need check the validity of buf length, because sometime the length may be a very very big number, I don't know why
if pl > 1024*10 {
fmt.Fprintf(os.Stderr, "vici recv len %v\n, %s", pl, debug.Stack())
return nil, fmt.Errorf("vici error: recv wrong data len %v", pl)
}
//netbank.cn

buf = make([]byte, int(pl))
_, err = t.conn.Read(buf)
if err != nil {
	return nil, fmt.Errorf("%v: %v", errTransport, err)
}

p := &packet{}
err = p.parse(buf)
if err != nil {
	return nil, err
}

return p, nil

}

[enr0n]

@weixiaolan2019 Please open a separate issue so we can keep things organized. 😄