Bump up version? about strophejs

[metajack]

I'm +1 on this, but I don't have time to do it myself.

I vote for 1.1.0 if it's backwards compatible API-wise. Otherwise it will have to be 2.0.

The checklist for doing releases is in the repo, and you can push to the web repos to update the website. Happy to help if someone takes this on and runs into trouble.

[Gordin]

The WebSocket stuff didn't change the API, other than that WebSockets don't have an "attach" like with BOSH. Also the Register-plugin from the plugin-repo won't work with WebSockets yet, but this is because the plugin overrides the StropheJS functions and uses BOSH manually (looks kinda hacky, I thought about rewriting it so that it would use functions from core that always use the right protocol, but never got around to do it). Not sure if this counts as backwards compatible.

Also, considering the low frequency of releases, we could look at #8 before releasing, I remember how it annoyed me when StropheJS would just silently throw away any Exceptions in my callbacks while developing with it. I think it would help devs that are just starting to develop with StropheJS if even when the Strophe loggers are not set up there would be SOME indication that something went wrong, like a console.log.

[metajack]

I wouldn't consider plugins breaking on internal apis breaking backwards compat, but we should document that in the release notes and try and ping the plugin authors if we can.

Missing attach() is fine, since it doesn't make sense at all for websockets.

[zooldk]

+1 Yes. So update the version to 1.1.0 and update the release notes and doc. If I can help in any case, say so.

[zooldk]

..And of course tag it for a final 1.1.0 release.

[Dirbaio]

There's also issue metajack/strophejs#59 which was fixed two years ago and breaks the most basic thing in XMPP: sending messages. This issue alone would have deserved a bugfix release.

#8 is pretty important too, having stuff fail and stop working for no apparent reason is quite irritating.

[meinharrd]

looks like @metajack is too busy with mozilla work. ;) so let's prepare a release?

according to release_checklist.txt we are at item 'Update CHANGELOG.txt'. i started a stub for 1.1 at https://github.com/meinharrd/strophejs/blob/master/CHANGELOG.txt

release-1.0.2...master lists 180 commits, so this might become quite a long list of changes. who can help grooming the commit list for log-relevant changes?

@Gordin: is #8 fixed? does it need review from @metajack or what stops it from being merged?

[Gordin]

@meinharrd More than half of the commits can probably be summarized as "WebSocket Support" ^^ I'll go through my commits and see if there's anything besides WebSocket in it.

I commented on #8. If no one objects I will merge it when the request is updated.

[taybin]

Any updates on this?

[meinharrd]

@taybin don't think so. let's check.. :)

@Gordin i think there were no objections to the merge. shall we merge, test and update the changelog? did you find anything else apart from websocket support that should be mentioned?

[taybin]

How about now?

[Gordin]

I looked at the history since 1.0.2 and wrote a 1.1.0 changelog on my branch: Gordin/strophejs@844b492

I would like to wait another few days before releasing though, because I would like to look at/fix #35 and #44 and also implement correct handling of namespaces for websockets before the release.

In the meantime please look at my changelog and comment if you find errors, missing features, typos...

[taybin]

Changelog looks good to me.

[Gordin]

I finished the internal changes to the WebSocket implementation now. It would be nice if some of you could test the current master with whatever application you use StropheJS for. Most of the changes I made were only to the internal handling of websocket messages, but I had to move around some of the message handling code in core.js a bit, so I just want to make sure I really didn't break anything. (Testsuite and everything I use StropheJS for works fine obviously)

I will start updating the documentation and if this works for everyone, I will tag this as 1.1.0.

[Gordin]

I prepared the release tarballs and the update for strophe.im now. If no one has a problem with it, I will release 1.1.0 tomorrow.

[zooldk]

+1 super

[Gordin]

I just tagged the current release and pushed the strophe.im website. 1.1.0 is now released :)

[zooldk]

Super job!