New feature: ability to do synchronous disconnect about strophejs

[Gordin]

I'm guessing Gordin/strophejs@a1f13b2 would fix this?

[samaxes]

Yes, probably.

Would the disconnect sequence be something like this?

connection.sync = true;
connection.send(new $pres({
    type: 'unavailable'
}));
connection.flush(); // Is this mandatory?
connection.disconnect();

[Gordin]

If you want to disconnect in a window close callback You would do

connection.options.sync = true;
connection.disconnect();
connection.flush();

disconnect automatically sends an unavailable presence and flush will make sure everything will be sent instantly.
If you just want to reconnect you should be able to just do

connection.disconnect();

and wait until the Connection Callback receives a DISCONNECTED before you reconnect. If this only works with synchronous connections, there maybe is a bug in the BOSH disconnect logic.

[samaxes]

I was expecting that the sync option would allow us not having to wait for the DISCONNECTED status.
When reconnecting after DISCONNECTED it works fine, there is no bug on the BOSH disconnect logic.

[Gordin]

Why exactly would you want to reconnect before DISCONNECTED? If you reconnect before DISCONNECTED the connection might not be fully cleaned up (although you will probably be fine if you call reset before reconnecting). Waiting for DISCONNECTED is definitely the way it's supposed to work. Also, it shouldn't take too long to wait for it either, worst case is 3 seconds after which a disconnect timeout triggers.

[samaxes]

For no reason in particular :)