GithubHelp home page GithubHelp logo

Comments (4)

Gordin avatar Gordin commented on July 28, 2024

Thanks for reporting, I will look into this.
(I edited your post to add syntax highlighting)

from strophejs.

Gordin avatar Gordin commented on July 28, 2024

I think the issue is that the BOSH code called this._doDisconnect(); when it should have called this._conn._doDisconnect();
The _doDisconnect of the connection will take care of calling disconnect methods of the protocol that is used and also set the connection status to DISCONNECTED afterwards.

@rj33 can you try this branch and tell me if this fixes the issue? https://github.com/Gordin/strophejs/tree/issue-57-fix

from strophejs.

rj33 avatar rj33 commented on July 28, 2024

Thanks Gordin! With your branch in place, the problems I was seeing are now gone. I'll do some more testing tomorrow, but it looks like your commit fixes the problem, and I haven't detected any negative side effects ( yet :-) ).

Thanks again,
Richard.

from strophejs.

rj33 avatar rj33 commented on July 28, 2024

Oh, and also further thanks for the super fast response, and your efforts in ongoing maintenance, as well as helping get the updated release out!

from strophejs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.