GithubHelp home page GithubHelp logo

Comments (29)

queso avatar queso commented on May 31, 2024 2

I feel like this is a core Meteor issue and likely not anything you are doing... Perhaps time to ping @tmesday or @benjamn?

from accounts-ui.

xavxyz avatar xavxyz commented on May 31, 2024 1

@queso solved it live just few minutes ago cloning the package repo (this one) directly into the packages folder of the app.

I tried this way of doing on an app of mine too, no more problems with dependencies! Everything runs fine! That's a way to handle it by now ๐Ÿ’ฏ

from accounts-ui.

timbrandin avatar timbrandin commented on May 31, 2024 1

I guess we can close then.

from accounts-ui.

tjramage avatar tjramage commented on May 31, 2024 1

@PolGuixe โ€“ I agree! I've just updated to 1.1.19 and latest tracker-component and still seeing the same issue.

cannot find module

from accounts-ui.

timbrandin avatar timbrandin commented on May 31, 2024 1

Yeah, seems like it works better for me on a clean app installation, anyone want to check out the devel version I've pushed, you could just clone it into /packages and checkout devel to try it out.

from accounts-ui.

raphaelkross avatar raphaelkross commented on May 31, 2024 1

@SachaG - perhaps deleting the node_modules, checking the versions at package.json and running npm install again remove any cache problem.

from accounts-ui.

VikR0001 avatar VikR0001 commented on May 31, 2024

Interesting. Via the console, I see that std_accounts-ui is loading. I have a breakpoint set on line 25148, and execution is halting at that breakpoint:

Line 25148: require("./node_modules/meteor/std:accounts-ui/check-npm.js");

Now here's the odd thing. That line is looking for the package at

./node_modules/meteor/std:accounts-ui

But it isn't installed there. In fact, there is no folder called "meteor" in my node_modules folder. std_accounts-ui is currently installed at

myApp/.meteor/local/build/programs/web.browser/packages/std_accounts-ui.js

How can I install std:accounts-ui in the place where it expects itself to be?

from accounts-ui.

timbrandin avatar timbrandin commented on May 31, 2024

What version of Meteor are you on? So that I can try to reproduce it during the day or this week.

from accounts-ui.

PolGuixe avatar PolGuixe commented on May 31, 2024

I am getting the same as in #29

You can reproduce it here: https://github.com/Zetoff/trajectory/tree/meteor-and-packages-update

from accounts-ui.

VikR1000 avatar VikR1000 commented on May 31, 2024

@timbrandin, I am in Meteor 1.3.1.

from accounts-ui.

tjramage avatar tjramage commented on May 31, 2024

I'm also having this issue since updating to 1.3.1.

from accounts-ui.

timbrandin avatar timbrandin commented on May 31, 2024

@VikR0001 alright, thx.

from accounts-ui.

PolGuixe avatar PolGuixe commented on May 31, 2024

In my case is independent from the Meteor version -1.3 or 1.3.1- , but since the std:accounts-ui was updated to 1.1.14.
std:[email protected] works fine.

from accounts-ui.

timbrandin avatar timbrandin commented on May 31, 2024

Ok, so I'll see with what those two versions differ.

from accounts-ui.

raphaelkross avatar raphaelkross commented on May 31, 2024

@timbrandin Also experiencing this issue - so I'll be waiting for more informations or even better, a fix!

Thank you!

from accounts-ui.

PolGuixe avatar PolGuixe commented on May 31, 2024

@timbrandin I don't think that cloning the package to the /packages folder is a legit solution.

from accounts-ui.

PolGuixe avatar PolGuixe commented on May 31, 2024

This is difficult to debug it myself since, if I clone the package to /packages then the error disappears.
Is there any way we can help?

from accounts-ui.

benjamn avatar benjamn commented on May 31, 2024

The errors about missing <npm-package>/package.json files are due to this code checking for packages that are never otherwise imported in this package or the app. When you don't import a package on the client, it doesn't get bundled into your app at allโ€”hence the missing module errors!

You can make those errors go away by putting

import "react";
import "react-dom";
import "tracker-component";

anywhere in your client code. I'm tempted to say std:accounts-ui shouldn't be checking those packages unless it imports them, but I suppose there may have been a good reason to check.

@tmeasday Perhaps the absence of a package.json file should be a sign that the package is never used, and therefore its version doesn't matter?

from accounts-ui.

tmeasday avatar tmeasday commented on May 31, 2024

So this issue was partly caused by an error in check-npm-versions' detection of missing modules on the client (fixed by Meteor-Community-Packages/check-npm-versions@f50c986, @benjamn what do you think about my janky string matching; do you have a better idea?)

If you update to tmeasday:[email protected] you should see a more informative error message (although maybe it's not that much more useful).

Ultimately though @benjamn is right, the package should import the things it's checking I suspect.

from accounts-ui.

tmeasday avatar tmeasday commented on May 31, 2024

Perhaps the absence of a package.json file should be a sign that the package is never used, and therefore its version doesn't matter?

I'm not sure this makes sense; what if the user has legitimately forgotten to install the npm package? How can we distinguish on the client?

from accounts-ui.

SachaG avatar SachaG commented on May 31, 2024

Running into the same issue, I'll downgrade back to 1.1.12 for now.

from accounts-ui.

timbrandin avatar timbrandin commented on May 31, 2024

I'm not sure how to handle this @SachaG, would it work better without tmeasday:check-npm-versions?

from accounts-ui.

timbrandin avatar timbrandin commented on May 31, 2024

Btw @benjamn I've noticed that if you update a local package in for example another folder, the .meteor/local built package inside the app doesn't update and get the new node_modules if they where updated, is that a bug with meteor?

from accounts-ui.

SachaG avatar SachaG commented on May 31, 2024

@timbrandin I guess? I'm not super clear on what's causing the issue but we can probably not use that package for now?

from accounts-ui.

PolGuixe avatar PolGuixe commented on May 31, 2024

Release 1.1.20 seems to be working fine.

Great job!

from accounts-ui.

timbrandin avatar timbrandin commented on May 31, 2024

Awesome. I'll close this then.

from accounts-ui.

SachaG avatar SachaG commented on May 31, 2024

Has this issue actually been fixed? I was using 1.2.6 and just ran into it again.

from accounts-ui.

limratana avatar limratana commented on May 31, 2024

I came across this issue and benjamn's solution seems to have solved the problem for me.

from accounts-ui.

 avatar commented on May 31, 2024

I am still hitting this issue. @benjamn importing tracker-component into my ui code doesn't seem to help :(

from accounts-ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.