GithubHelp home page GithubHelp logo

Comments (3)

kitten avatar kitten commented on July 19, 2024 1

Yes, a couple of things still misbehave since next.js has not added an API for wrapping the app yet: https://github.com/styled-components/styled-components-website/blob/master/pages/_document.js#L140

So some code is not migrated / changed yet and just there to "make things work". 😉 😆

from styled-components-website.

kitten avatar kitten commented on July 19, 2024 1

@pronevich this page is not using the ThemeProvider, but no. Apart from the duplication there's no harm. But repeating yourself is often bad practice, so it should be avoided.

I'm not sure whether you're referring to the stylesheet manager instead? It can't be repeated, since we need to inject the resulting style tags into the head of the document statically during SSR.

Please move questions unrelated to this site into a new issue on the SC repo :)

from styled-components-website.

pronevich avatar pronevich commented on July 19, 2024

@philpl Is there any drawbacks to use <ThemeProvider> for each page?

from styled-components-website.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.