GithubHelp home page GithubHelp logo

Comments (7)

mxstbr avatar mxstbr commented on May 4, 2024 1

Done by the amazing @nickgnd in #121! 🎉

from styled-components.

nickgnd avatar nickgnd commented on May 4, 2024

Hi @mxstbr, I'd like work on this 😄
I'll let you know how i proceed and I'll send you PR asap

from styled-components.

mxstbr avatar mxstbr commented on May 4, 2024

Awesome, let me know how it goes!

from styled-components.

mxstbr avatar mxstbr commented on May 4, 2024

Hey @nickgnd, just wondering if you maybe ran into issues? Can I help?

from styled-components.

nickgnd avatar nickgnd commented on May 4, 2024

Hi @mxstbr, it's all ok :) Thanks for your interesting. I think I'll be able to send you a PR tomorrow night with almost all the rules you listed in the first comment, then we can improve them to better fit the project's needs.

The only thing a bit difficult is to test the rules specified because, also if I run Danger locally, it tests the rules against the latest Github PR, but it's not blocking

from styled-components.

mxstbr avatar mxstbr commented on May 4, 2024

I think I'll be able to send you a PR tomorrow night with almost all the rules you listed in the first comment, then we can improve them to better fit the project's needs.

Awesome, sounds good to me! Feel free to submit a WIP PR so you can iterate on the output, that should also solve the second issue!

from styled-components.

nickgnd avatar nickgnd commented on May 4, 2024

@mxstbr wow, thanks! Let me know if you need further help to adjust Danger's rules or in other on ruby stuff 🤓 💎

from styled-components.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.