GithubHelp home page GithubHelp logo

Comments (6)

jeddy3 avatar jeddy3 commented on May 22, 2024

I just noticed that scsslint has two rules for this, with slightly different purposes:

Trailing Zeros is for when there is a faction with extra zeros at the end e.g. 5.55500000px and Unnecessary Mantissa is for when an integer has a unnecessary faction after it e.g. 5.0px.

Is there value in us being this specific? I guess they are kind of different things. Thoughts? Should we go with?:

  • number-no-trailing-zeros: Disallow trailing zeros (e.g. 5.55000px)
  • number-no-unnecessary-mantissa: Disallow unnecessary mantissa (e.g. 5.0px)

from stylelint.

MoOx avatar MoOx commented on May 22, 2024

I found this overkill. 5.55000px is just useless like 5.0px. Looks the same to me.

from stylelint.

davidtheclark avatar davidtheclark commented on May 22, 2024

Yeah, I sort of think that distinction only happened because somebody with a math background new what "mantissa" is? I don't about the use-case. Did you search the issues to see if there was some justification for it?

from stylelint.

jeddy3 avatar jeddy3 commented on May 22, 2024

Did you search the issues to see if there was some justification for it?

Yeap, but I couldn't find anything.

Sounds like we're agreed it's overkill anyway.

Shall we call our one rule number-no-trailing-zeros (note the s at the end) as then it makes it a little clearer that it'll flag up 1 or more trailing zeros i.e. both 5.55000px and 5.0px?

from stylelint.

MoOx avatar MoOx commented on May 22, 2024

why not

from stylelint.

davidtheclark avatar davidtheclark commented on May 22, 2024

sure

from stylelint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.