Comments (6)
I just noticed that scsslint has two rules for this, with slightly different purposes:
Trailing Zeros is for when there is a faction with extra zeros at the end e.g. 5.55500000px
and Unnecessary Mantissa is for when an integer has a unnecessary faction after it e.g. 5.0px
.
Is there value in us being this specific? I guess they are kind of different things. Thoughts? Should we go with?:
number-no-trailing-zeros
: Disallow trailing zeros (e.g.5.55000px
)number-no-unnecessary-mantissa
: Disallow unnecessary mantissa (e.g.5.0px
)
from stylelint.
I found this overkill. 5.55000px is just useless like 5.0px. Looks the same to me.
from stylelint.
Yeah, I sort of think that distinction only happened because somebody with a math background new what "mantissa" is? I don't about the use-case. Did you search the issues to see if there was some justification for it?
from stylelint.
Did you search the issues to see if there was some justification for it?
Yeap, but I couldn't find anything.
Sounds like we're agreed it's overkill anyway.
Shall we call our one rule number-no-trailing-zeros
(note the s at the end) as then it makes it a little clearer that it'll flag up 1 or more trailing zeros i.e. both 5.55000px
and 5.0px
?
from stylelint.
why not
from stylelint.
sure
from stylelint.
Related Issues (20)
- Create option to extend rule: no-duplicate-at-import-rules HOT 1
- Create option to extend rule: no-unknown-animations HOT 1
- CLI doesn't seem to work as expected. HOT 2
- [16.4.0] Cannot suppress `selector-max-universal` HOT 4
- Add regex support to `value-no-vendor-prefix` secondary option
- Provide links to message HOT 3
- Fix `shorthand-property-no-redundant-values` false negatives for `var()` HOT 10
- Add flags/options to set custom exit codes depending on the severity HOT 10
- TypeScript reports "Type 'CosmiconfigResult' is not generic" HOT 1
- Release 16.5.0 HOT 5
- Create option to extend rule: font-family-no-duplicate-names HOT 1
- Create option to extend rule: no-duplicate-at-import-rules
- Create option to extend rule: no-unknown-animations
- Stylelint --fix does not fix two problems at the same time: the order/properties-order property, and the removal of extra empty lines. HOT 4
- no-missing-end-of-source-newline false positive after upgrade to v16.4.0 (from 15.11.0) HOT 1
- SCSS: Issue with double slash comment HOT 1
- DeprecationWarning: fs.Stats constructor is deprecated HOT 6
- Node.js API should allow fixing a list of files in-place HOT 2
- Rule idea: `declaration-prefer-shorthand` HOT 2
- Fix `selector-type-no-unknown` false positive for `model`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stylelint.