[Safari+Cascadea] Your own comments have almost white border color about github-dark

[jimeh]

Indeed, seems like it's an undocumented feature of the parser in Stylus, implemented here from what I can tell: https://github.com/openstyles/stylus/blob/v1.5.22/js/usercss-compiler.js#L66-L95

Tracing it back, it looks like it's been part of the UserCSS implementation from the beginning, added in openstyles/stylus#134 (js/usercss.js, lines 62-89). Just one of those somewhat quirky features that never got documented and has been flying under the radar ever since :)

[mikefreuden]

I actually did some digging and found it to be an old USo feature! Will definitely add support for this in the next Cascadea update.

Oh, the fun of implementing your own UserCSS parser/compiler from scratch. :)

[mikefreuden]

I've actually had this implemented for a week now and was going to wait until I had a few more fixes or changes in place to bother shipping it, but given that might be a while, I've gone ahead and pushed Cascadea 2.1.3 to the App Store which should support this:

It's still waiting for Apple approval (edit: approved!), but once it's out, you should just need to have Cascadea recompile GitHub Dark (which will happen automatically when updating, or if you open the Style Properties window and click "Save") for it to properly apply these variables.

[the-j0k3r]

Have you tested chrome/firefox + stylus? Are you using the latest version of this style?

[jimeh]

@the-j0k3r Yep, it works fine in Chrome and Firefox using Stylus. Everything is fully updated; browsers, Stylus, Cascadea, and the GitHub Dark userstyle CSS.

Hence I suspect maybe it's Cascadea that lacks support for the -rgb thing on color options?

[the-j0k3r]

The dev is around and pingable. @mikefreuden

This one is all yours, thx ;)

@jimeh no worries thanks for actually testing. ;)

[mikefreuden]

Oh hello!

I'd be happy to fix this on Cascadea's end, but I'm not quite sure I understand what GitHub Dark is doing here. There's indeed no base-color-rgb variable defined in the UserCSS header. I'm assuming Stylus added support for some way to specify the format of a color variable by appending the format to it or something along those lines that I missed out on and isn't documented in the Writing UserCSS article? 😅

[jimeh]

For now I have made a quick hack userstyle to work around the issue. It simply overrides the specific CCS variables affected. I use the default Base Color in GitHub Dark (#4f8cc9), which is 79, 140, 201 in RGB values.

@-moz-document domain("githubusercontent.com"), domain("githubstatus.com"), domain("github.com")
{
	:root:root:root {
		--color-accent-muted: rgba(79, 140, 201, .3);
		--color-auto-blue-2: rgba(79, 140, 201, .25);
		--color-auto-blue-3: rgba(79, 140, 201, .5);
		--color-calendar-graph-day-L1-bg: rgba(79, 140, 201, .25);
		--color-calendar-graph-day-L2-bg: rgba(79, 140, 201, .5);
		--color-calendar-graph-day-L3-bg: rgba(79, 140, 201, .75);
		--color-primer-shadow-focus: 0 0 0 2.25px rgba(79, 140, 201, .3);
		--color-state-focus-shadow: 0 0 0 2.25px rgba(79, 140, 201, .3);
	}
}

[jimeh]

@mikefreuden thanks, I just updated to Cascadea 2.1.3 and things all work as expected now :D