GithubHelp home page GithubHelp logo

Comments (12)

obuchtala avatar obuchtala commented on June 9, 2024 2

merged #1196 with a fix for detecting invalid render() implementation.

from substance.

e-e-e avatar e-e-e commented on June 9, 2024 1

You don't need to apologise - I am really enjoying using substance and am happy to help contribute by finding any issues.
Thanks so much for making such a great open source library.

from substance.

obuchtala avatar obuchtala commented on June 9, 2024 1

That would be a wonderful contribution!

from substance.

obuchtala avatar obuchtala commented on June 9, 2024

ATM, this must be a regular element. But please feel free to turn this issue into a feature request. This was definitely something we were also wanting several times.

from substance.

e-e-e avatar e-e-e commented on June 9, 2024

Ah cool - good to know its a know constraint! Thank you @oliver----. I will modify the title of the issue to make it into a feature request.

In the mean time - it could be beneficial to catch this and warn the user. Might save some folk some time in debugging. I definitely just spent way too long diagnosing this.

from substance.

obuchtala avatar obuchtala commented on June 9, 2024

Yeah. Sorry about the debugging experience.
Will do what you suggested!

from substance.

obuchtala avatar obuchtala commented on June 9, 2024

At least I found that we have a check in the code already ;)
So you saw an exception "Component.render must return VirtualHTMLElement", didn't you?
Should improve the error message. And documentation-wise we are not at all in a good place.

from substance.

e-e-e avatar e-e-e commented on June 9, 2024

Actually no - I did not see that error at all. But perhaps that is a version issue - and I should update to the latest.

Its tough - without docs - I have just been reading your code. I should probably be helping also by contributing back documentation as I go.

from substance.

obuchtala avatar obuchtala commented on June 9, 2024

Re: exception. I can confirm that the test I have for that is not sufficient. So this slipped through.

from substance.

obuchtala avatar obuchtala commented on June 9, 2024

Returning $$(Component) is on the way...
15375f3

from substance.

michael avatar michael commented on June 9, 2024

Working now with preview.75.

from substance.

e-e-e avatar e-e-e commented on June 9, 2024

Amazing - thanks guys.

from substance.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.