Comments (12)
merged #1196 with a fix for detecting invalid render()
implementation.
from substance.
You don't need to apologise - I am really enjoying using substance and am happy to help contribute by finding any issues.
Thanks so much for making such a great open source library.
from substance.
That would be a wonderful contribution!
from substance.
ATM, this must be a regular element. But please feel free to turn this issue into a feature request. This was definitely something we were also wanting several times.
from substance.
Ah cool - good to know its a know constraint! Thank you @oliver----. I will modify the title of the issue to make it into a feature request.
In the mean time - it could be beneficial to catch this and warn the user. Might save some folk some time in debugging. I definitely just spent way too long diagnosing this.
from substance.
Yeah. Sorry about the debugging experience.
Will do what you suggested!
from substance.
At least I found that we have a check in the code already ;)
So you saw an exception "Component.render must return VirtualHTMLElement"
, didn't you?
Should improve the error message. And documentation-wise we are not at all in a good place.
from substance.
Actually no - I did not see that error at all. But perhaps that is a version issue - and I should update to the latest.
Its tough - without docs - I have just been reading your code. I should probably be helping also by contributing back documentation as I go.
from substance.
Re: exception. I can confirm that the test I have for that is not sufficient. So this slipped through.
from substance.
Returning $$(Component)
is on the way...
15375f3
from substance.
Working now with preview.75.
from substance.
Amazing - thanks guys.
from substance.
Related Issues (20)
- Found a case where XMLDocumentNode.find() does not find a direct child HOT 1
- [question] The best practice for loading an asynchronous document into an editor
- Asciidoc backend? HOT 1
- A selection should not be allowed to point to a non existing surface HOT 1
- Edit inline node is not working for nodes which goes one after another HOT 4
- Why does substance depend on substance? HOT 2
- ES5 support? HOT 4
- Allow to insert before first node if it is an isolated node. HOT 11
- Plans to an import-HTML module?
- Error in "isDisabled" function in InsertInlineNodeCommand class
- Importing references without doi HOT 1
- CDATA Text elements makes schema invalid HOT 1
- DOM.parseSnippet() provides two elements when content is CDATA
- Clicking on InlineNode inside of IsolatedNode selects the IsolatedNode HOT 1
- Strange DOM selection after click
- Draggable InlineNodes have a strange selection in Chrome HOT 1
- JS-YAML Error HOT 1
- npm start does not work as described in README.md HOT 2
- Is substance.io died? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from substance.