Comments (5)
This is interesting. We were recently talking about how it's annoying to deal with it in two places and I totally forgot this issue. scope.timeout
didn't quite work because you have to set cucumber's timeout before scope becomes available. Maybe an env variable would be useful for this at least for us as test framework developers. Also see #82 (allow devs to set timeouts somewhat arbitrarily to allow for known big documents or long load times). Would we ever make it into a secret? @niharikasingh , @berit ?
Also, we should test whether the page timeout circumvents the cucumber timeout when it's shorter. Does that mean we want cucumber to always have an infinite timeout? Hmm, not sure, cucumber things can still go wrong. Unfortunately, modifying the cucumber timeout is more difficult (you have to pass it in as an argument), but it may be better to handle that on a case-by-case basis.
from alkiln.
I don't think timeouts need to be secret. They can probably be in the public .env
file or any other public file we want.
The only reason to make them a secret would be if it is easier to make everything a secret, just for consistency's sake.
from alkiln.
Something like an alkiln.config is worth thinking about. I hesitate to add another file to upkeep as we develop the package, but secrets are somewhat obstructive as an all-purpose tool for storing preferences since you can't see what's in them. Still, it would be another file to update...
from alkiln.
Maybe we could have a config in this library and overwrite it with a local config if people make one. My brain isn't currently telling me how that could be done.
from alkiln.
We now have a global var and a Step for custom max Step time that should work per Scenario (once it's fixed). That seems good enough for now. I think adding a config would make things more confusing.
If devs find it way too annoying to set for each Scenario, it'll be worth reconsidering.
from alkiln.
Related Issues (20)
- Parse file in workflow: Test if failed tests make issue
- Parse file in outer workflow: Test if failed tests make issue
- Parse file in outer workflow: Test if failed tests make issue
- Parse file in outer workflow: Test if failed tests make issue
- Parse file in outer workflow 1 internal: Test if failed tests make issue
- Parse file in outer workflow 2 from output: Test if failed tests make issue
- Parse file in outer workflow 1 internal: Test if failed tests make issue
- Parse file in outer workflow 2 from output: Test if failed tests make issue
- Parse file in outer workflow 2 from output: Test if failed tests make issue
- Parse file in outer workflow 2 from output: Test if failed tests make issue
- Parse file in outer workflow 2 from output: Test if failed tests make issue
- Parse file in outer workflow 2 from output: Test if failed tests make issue
- ALKiln tests failed
- ALKiln tests failed
- Add warning for wrong node version
- When origin is playground, create user/interview-specific runtime_config vals
- ALKiln tests failed HOT 1
- ALKiln tests failed HOT 1
- ALKiln tests failed HOT 1
- Add workflow with issue creation option to setup interview with option to create issue on separate repo HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from alkiln.