GithubHelp home page GithubHelp logo

Comments (6)

EmilyOng avatar EmilyOng commented on July 29, 2024

Hello Quozl, please take a look at this :)

I have simplified the clock translation by:


        time(12, 0) => twelve noon |
        time(0, 0) => midnight |
        time(h, 0) => hour(h) o'clock am_pm(h) |
        time(h, m) [m < 10] => hour(h) o' min(m) am_pm(h) |
	time(h, m) [m >= 10] => hour(h) min(m) am_pm(h) |

  1. Changing the output of time(12, 0) to twelve noon instead of hour(12), because for the sake of simplification, I have removed 'noon', 'midnight' and 'quarter' from the list of strings (Same goes for midnight)
  2. I actually though that if we indicated the time as "eleven one" or "ten two", it will be rather weird. So I added a rule, where if the minute(m) is less than 10, it will read "eleven o' one" instead. How is this?
  3. In addition, I removed the "minutes" in the rules.

Please let me know how this is, thank you so much!

Commits
https://github.com/EmilyOng/clock-activity/blob/simplify-t/test_timewriter/LANG_rules.py

Output
timewriter.txt

from clock-activity.

quozl avatar quozl commented on July 29, 2024

@EmilyOng, thanks. From discussion in #11 the intention was to substantially simplify both what is spoken and how it appears in the source code so that translators will engage using their limited tools. They don't want to have to change source files, only po/*.po files. You may have to explain your proposal to me further, 'cause I'm not very familiar with the code.

from clock-activity.

leonardcj avatar leonardcj commented on July 29, 2024

What needs to happen is to eliminate this very ugly string entry which requires insertion of all sorts of markup

https://translate.sugarlabs.org/en/Clock/translate/#filter=all&unit=960927

Basically, this needs to abandon a rotary clcck face for a digital clock readout.

from clock-activity.

quozl avatar quozl commented on July 29, 2024

Thanks @leonardcj, there are two issues then;

  • the HTML markup, and;
  • the length of the entry.

The HTML markup is for text colouring to match the colour of the clock hands or digits, and might be moved out of the translatable string and into the source code. This will also slightly reduce the length.

The length of the entry can be further reduced by one or more of the following;

  • removing the nearly duplicate hour1 rules and instead calculate them from the hour rules,
  • switching to smaller keywords, such as h instead of hour,
  • simplifying the rules as @EmilyOng has done.

I don't think the clock face needs to change, just the way it is spoken or described by text.

@EmilyOng, you might also look around for Python library or source code that speaks a time of day; we might accept it if it has good code quality, good license, and internationalisation support using gettext.

from clock-activity.

EmilyOng avatar EmilyOng commented on July 29, 2024

from clock-activity.

quozl avatar quozl commented on July 29, 2024

@leonarcj, this is now complete, please test.

Final genpot change here;
9a5451a

from clock-activity.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.