GithubHelp home page GithubHelp logo

Comments (4)

oriolpuig avatar oriolpuig commented on September 22, 2024 1

I've tried to solve that issue and I think we can manage it adding a condition at href link attribute. I don't know if It won't be fixed at 100% but it is working at Chrome, Safari and Firefox browsers.

It would be something like code bellow:

    <Link
      {...attrs}
      href={!disabled && href}
      target={target}
      rel={target === '_blank' ? 'noopener' : undefined}
    >
      {children}
    </Link>

What do you think about that?

from sui-components.

midudev avatar midudev commented on September 22, 2024 1

Do a PR @oriolpuig!

from sui-components.

JoanClaret avatar JoanClaret commented on September 22, 2024

@turolopezsanabria : disabled link buttons still redirecting, so we can't close this PR yet.

from sui-components.

oriolpuig avatar oriolpuig commented on September 22, 2024

This issue has been fixed on PR #871

from sui-components.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.