GithubHelp home page GithubHelp logo

Comments (3)

bdjnk avatar bdjnk commented on July 17, 2024 1

I've tested your fork on my set of SVGs. No errors presented and the bugs I was experiencing have evidently been resolved.

Thank you @markadrake!

from webfonts-generator.

markadrake avatar markadrake commented on July 17, 2024

I forked the repo and updated the dependencies, then ran the tests. The tests passed, except for a small issue with the RENDERED_TEMPLATE having a return character \r before the newline. I updated the test too so that it passed. The only other update I had to make was calling svgicons2svgfont with new.

Mind testing it out? Should anything else be done before submitting a PR?

https://github.com/markadrake/webfonts-generator/commit/387029ee051a181a1740177ca5eea7d64ee58fe2

from webfonts-generator.

markadrake avatar markadrake commented on July 17, 2024

You are very welcome @bdjnk. It also resolved some quirks I noticed with my own SVG icons.

Wondering how to push the PR forward though - not a lot of experience on my end committing to public open source projects like this. Any tips or suggestions? Looks like part of the reason my PR failed was due to some outdated node versions so that's immediately a major release. I get that, but no response from the maintainer :/

from webfonts-generator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.