Comments (3)
I've tested your fork on my set of SVGs. No errors presented and the bugs I was experiencing have evidently been resolved.
Thank you @markadrake!
from webfonts-generator.
I forked the repo and updated the dependencies, then ran the tests. The tests passed, except for a small issue with the RENDERED_TEMPLATE
having a return character \r
before the newline. I updated the test too so that it passed. The only other update I had to make was calling svgicons2svgfont
with new
.
Mind testing it out? Should anything else be done before submitting a PR?
https://github.com/markadrake/webfonts-generator/commit/387029ee051a181a1740177ca5eea7d64ee58fe2
from webfonts-generator.
You are very welcome @bdjnk. It also resolved some quirks I noticed with my own SVG icons.
Wondering how to push the PR forward though - not a lot of experience on my end committing to public open source projects like this. Any tips or suggestions? Looks like part of the reason my PR failed was due to some outdated node versions so that's immediately a major release. I get that, but no response from the maintainer :/
from webfonts-generator.
Related Issues (20)
- use lodash instead of underscore
- Works for all IE but IE9 HOT 2
- support ligatures HOT 3
- scss template doesn't write correct charcode
- Invalid XML causes an uncatchable error to be thrown
- Icon resizing/centering within a boundary HOT 2
- Max number of ligatures? HOT 1
- Fails eslint node/no-unpublished-require rule validation
- removePeriods is not registered HOT 2
- Using glob on files path
- Poor glyphs quality HOT 1
- There is error when generate one svg icon to font HOT 3
- rendering issue HOT 2
- Get MIT licensed so we can use this in production
- adding new codepoints to codepoints.json
- SVG rendering with black background HOT 4
- no classprefix in preview html element?
- Update the npm package HOT 1
- SyntaxError: invalid syntax on Install
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from webfonts-generator.