GithubHelp home page GithubHelp logo

Comments (3)

5long avatar 5long commented on August 16, 2024

TL;DR - Will do after #92 is merged.

After using mime-decode hook to view HTML-only emails, I'm feeling the same need for this to be configurable.

A super-clean-and-correct approach would be extract the snippet-composing logics from message-loading time and move it to rendering time.

But for now I can settle with a config-based solution since the message-loading time already reads from config.

Besides, the truncating logic doesn't look good on non-ascii string. I'll wait for merging #92 first, which introduces wide-char-aware slicing.

from sup.

gauteh avatar gauteh commented on August 16, 2024

I think snippets are stored in the index, while re-calculating a snippet would require the message source to be read again. Worth taking into consideration. Upping the snippet length to say 250 chars and then using a screen-size dependent length at render time could be an option.

from sup.

gauteh avatar gauteh commented on August 16, 2024

Closing, no activity.

from sup.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.