GithubHelp home page GithubHelp logo

Comments (4)

marcuspoehls avatar marcuspoehls commented on July 25, 2024 1

@francislavoie Yeah definitely, the action should validate the input before starting the Docker container. Would avoid frustration and confusion in case of issues. Thank you for making it obvious 👍

from redis-github-action.

marcuspoehls avatar marcuspoehls commented on July 25, 2024

@francislavoie Hey Francis, I think you’re not defining a Redis version in your GitHub Actions workflow file.

Here’s a sample config using Redis 4, 5, and 6:

name: Run tests

on: [push]

jobs:
  build:
    runs-on: ubuntu-latest
    strategy:
      matrix:
        redis-version: [4, 5, 6]

from redis-github-action.

francislavoie avatar francislavoie commented on July 25, 2024

I did actually Vectorface/cache@7f6a103 but oops, just noticed I made a typo with plural s 😬 my bad!

from redis-github-action.

francislavoie avatar francislavoie commented on July 25, 2024

That said, the error could probably be more useful. Maybe this action should validate that the version number looks reasonable (non-empty etc) before trying to run Docker? Would have saved me from this confusion 😅

from redis-github-action.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.