Comments (6)
@swedishmike that's a good idea, we might also just make it a positional argument... so that's it more like unix command line tools. So
python blah.py filename
I think I like that even better, if you want to give it a swing feel free.
Here's the docs on that if you need it: https://docs.python.org/2/library/argparse.html
Approving PRs yourself is fine for smaller stuff like this, obviously just make sure all the automated tests pass and do a few yourself.
Cheers and thanks so much for contributing to the project, it's great to have the help.
from zat.
Sure thing - I'll give that a go and will test it locally thoroughly before even submitting the PR for automated tests.
I'll probably submit this tomorrow - gives me time to test and 'make it right'.
Absolutely no worries at all - it's all my pleasure. It's a great project and I'm happy that I can contribute in a small way.
Cheers, Mike
from zat.
You probably know all this already but since your a dev on the project you can just check out this repo make a local branch and then push that local branch and make a PR
$ git checkout -b my_branch
<work on stuff>
$ git push -u origin my_branch
from zat.
Yeah - just wanted to check that it was ok with you to do it that way and just didn't get around to it yet. ;)
Will do that from now on.
from zat.
@brifordwylie All tested and merged now. Have a look and see what you think - if you're happy with it let me know and I'll close this issue.
from zat.
Looks great :)
from zat.
Related Issues (20)
- What's the principle behind anomaly_detection? HOT 2
- what's your zeek scripts , can you share for me
- Error installing with python3.9 and numpy 1.19 HOT 2
- Add flake8 check to examples/
- Setup coveralls in Git Actions HOT 1
- Make pyspark dependency optional HOT 2
- Support for Intelligence Framework HOT 7
- How to make sure the dataframe_to_matrix function perform same on the data with same structure? HOT 3
- ZAT may ignore contents after character '#' HOT 8
- Demo file has errors HOT 1
- http.log file with the size of 2.0 MB zat stuck HOT 1
- Unable to run the code HOT 3
- Stuck when attempting to make a Pandas DF HOT 4
- Loading Data from S3 HOT 2
- Can we make JSON a first class citizen? HOT 2
- Multiple log files into a single dataframe HOT 1
- dosn't work
- About no output HOT 3
- Zeek to Parquet With Spark Gives Different Timestamp HOT 11
- Library issues -any suggestions HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zat.