GithubHelp home page GithubHelp logo

Comments (6)

brifordwylie avatar brifordwylie commented on June 14, 2024

@swedishmike that's a good idea, we might also just make it a positional argument... so that's it more like unix command line tools. So

python blah.py filename

I think I like that even better, if you want to give it a swing feel free.

Here's the docs on that if you need it: https://docs.python.org/2/library/argparse.html

Approving PRs yourself is fine for smaller stuff like this, obviously just make sure all the automated tests pass and do a few yourself.

Cheers and thanks so much for contributing to the project, it's great to have the help.

from zat.

swedishmike avatar swedishmike commented on June 14, 2024

Sure thing - I'll give that a go and will test it locally thoroughly before even submitting the PR for automated tests.

I'll probably submit this tomorrow - gives me time to test and 'make it right'.

Absolutely no worries at all - it's all my pleasure. It's a great project and I'm happy that I can contribute in a small way.

Cheers, Mike

from zat.

brifordwylie avatar brifordwylie commented on June 14, 2024

You probably know all this already but since your a dev on the project you can just check out this repo make a local branch and then push that local branch and make a PR

$ git checkout -b my_branch
<work on stuff>
$ git push -u origin my_branch

from zat.

swedishmike avatar swedishmike commented on June 14, 2024

Yeah - just wanted to check that it was ok with you to do it that way and just didn't get around to it yet. ;)

Will do that from now on.

from zat.

swedishmike avatar swedishmike commented on June 14, 2024

@brifordwylie All tested and merged now. Have a look and see what you think - if you're happy with it let me know and I'll close this issue.

from zat.

brifordwylie avatar brifordwylie commented on June 14, 2024

Looks great :)

from zat.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.